From be1dd6730a4ba621b4fb9db1b2717fb36960469f Mon Sep 17 00:00:00 2001 From: Ihar Hrachyshka Date: Tue, 29 Jul 2014 17:25:24 +0200 Subject: Make sure we don't throw away exception on SQL script failure If SQL script failed, we don't currently log the failure anywhere, so users have hard time debugging an issue, if anything arises. Let's log the failure before proceeding with rollback. Change-Id: Ic92b1403c00bb238a68265a15150a4be6f6b2346 --- migrate/versioning/script/sql.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migrate/versioning/script/sql.py b/migrate/versioning/script/sql.py index fdc9e2b..40d628f 100644 --- a/migrate/versioning/script/sql.py +++ b/migrate/versioning/script/sql.py @@ -42,7 +42,8 @@ class SqlScript(base.BaseScript): else: conn.execute(text) trans.commit() - except: + except Exception as e: + log.error("SQL script %s failed: %s", self.path, e) trans.rollback() raise finally: -- cgit v1.2.1