From 4a4566b59a07289ebe6e18bf351ad666fa419a00 Mon Sep 17 00:00:00 2001 From: Seongchuel Ahn Date: Mon, 8 May 2023 20:16:26 +0900 Subject: Fix `xadd` allow non negative maxlen (#2739) * Fix xadd allow non negative maxlen * Update change log --------- Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com> --- CHANGES | 1 + redis/commands/core.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGES b/CHANGES index ea171f6..4917980 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,4 @@ + * Fix `xadd` command to accept non-negative `maxlen` including 0 * Revert #2104, #2673, add `disconnect_on_error` option to `read_response()` (issues #2506, #2624) * Add `address_remap` parameter to `RedisCluster` * Fix incorrect usage of once flag in async Sentinel diff --git a/redis/commands/core.py b/redis/commands/core.py index 1a4acb2..f2d7bf2 100644 --- a/redis/commands/core.py +++ b/redis/commands/core.py @@ -3496,8 +3496,8 @@ class StreamCommands(CommandsProtocol): raise DataError("Only one of ```maxlen``` or ```minid``` may be specified") if maxlen is not None: - if not isinstance(maxlen, int) or maxlen < 1: - raise DataError("XADD maxlen must be a positive integer") + if not isinstance(maxlen, int) or maxlen < 0: + raise DataError("XADD maxlen must be non-negative integer") pieces.append(b"MAXLEN") if approximate: pieces.append(b"~") -- cgit v1.2.1