From 62afb8914aa6855310eae9f25114ca1ea41cbc34 Mon Sep 17 00:00:00 2001 From: Robert Godfrey Date: Mon, 27 Feb 2012 17:07:41 +0000 Subject: QPID-24 : [Java Broker] Fix potential leak of preparedstatement on exception in derby store git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1294230 13f79535-47bb-0310-9956-ffa450edef68 --- .../main/java/org/apache/qpid/server/store/DerbyMessageStore.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'qpid/java') diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/store/DerbyMessageStore.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/store/DerbyMessageStore.java index 2cc9a5423e..4d63136a9d 100644 --- a/qpid/java/broker/src/main/java/org/apache/qpid/server/store/DerbyMessageStore.java +++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/store/DerbyMessageStore.java @@ -2251,11 +2251,12 @@ public class DerbyMessageStore implements MessageStore, DurableConfigurationStor PreparedStatement pstmt = conn.prepareStatement(SELECT_ALL_FROM_XID_ACTIONS); - pstmt.setLong(1, xid.getFormat()); - pstmt.setBytes(2, xid.getGlobalId()); - pstmt.setBytes(3, xid.getBranchId()); try { + pstmt.setLong(1, xid.getFormat()); + pstmt.setBytes(2, xid.getGlobalId()); + pstmt.setBytes(3, xid.getBranchId()); + ResultSet rs = pstmt.executeQuery(); try { -- cgit v1.2.1