From 601c4d2bee2e7e02bad427d9c836bdc6e107cd26 Mon Sep 17 00:00:00 2001 From: Martin Ritchie Date: Mon, 3 Aug 2009 13:25:40 +0000 Subject: Removed stale constructor, updated two test cases to use other constructor, there is no impact as the tests were passing in null for the removed parameter git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@800365 13f79535-47bb-0310-9956-ffa450edef68 --- .../qpid/server/protocol/AMQMinaProtocolSession.java | 14 -------------- .../qpid/server/protocol/AMQProtocolSessionMBeanTest.java | 3 +-- .../org/apache/qpid/server/protocol/MaxChannelsTest.java | 2 +- 3 files changed, 2 insertions(+), 17 deletions(-) (limited to 'qpid/java') diff --git a/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java b/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java index c84408e680..1da5b1c26e 100644 --- a/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java +++ b/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java @@ -177,20 +177,6 @@ public class AMQMinaProtocolSession implements AMQProtocolSession, Managable } } - // This is only used by two tests that do provide null values for stateManager - // so we can safely remove this and refactor. - public AMQMinaProtocolSession(IoSession session, VirtualHostRegistry virtualHostRegistry, AMQCodecFactory codecFactory, - AMQStateManager stateManager) throws AMQException - { - _stateManager = stateManager; - _minaProtocolSession = session; - session.setAttachment(this); - - _codecFactory = codecFactory; - - _actor = new AMQPConnectionActor(this, virtualHostRegistry.getApplicationRegistry().getRootMessageLogger()); - } - private AMQProtocolSessionMBean createMBean() throws AMQException { try diff --git a/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBeanTest.java b/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBeanTest.java index f09b03ab85..6050512679 100644 --- a/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBeanTest.java +++ b/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBeanTest.java @@ -111,8 +111,7 @@ public class AMQProtocolSessionMBeanTest extends TestCase IApplicationRegistry appRegistry = ApplicationRegistry.getInstance(); _protocolSession = - new AMQMinaProtocolSession(new TestIoSession(), appRegistry.getVirtualHostRegistry(), new AMQCodecFactory(true), - null); + new AMQMinaProtocolSession(new TestIoSession(), appRegistry.getVirtualHostRegistry(), new AMQCodecFactory(true)); // Need to authenticate session for it to work, (well for logging to work) _protocolSession.setAuthorizedID(new Principal() { diff --git a/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/MaxChannelsTest.java b/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/MaxChannelsTest.java index 9597c1319a..fb0f746280 100644 --- a/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/MaxChannelsTest.java +++ b/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/MaxChannelsTest.java @@ -41,7 +41,7 @@ public class MaxChannelsTest extends TestCase public void testChannels() throws Exception { _session = new AMQMinaProtocolSession(new TestIoSession(), _appRegistry - .getVirtualHostRegistry(), new AMQCodecFactory(true), null); + .getVirtualHostRegistry(), new AMQCodecFactory(true)); // Need to authenticate session for it to work, (well for logging to work) _session.setAuthorizedID(new Principal() -- cgit v1.2.1