From 9659efe01f8d8cb2b4b3e1a27d16de35bd8d7db7 Mon Sep 17 00:00:00 2001 From: Ted Ross Date: Mon, 15 Sep 2008 15:37:59 +0000 Subject: QPID-1274 - Changed C++ namespace for generated management code. Improved efficiency of generated functions to use const references for non-simple types. git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk@695511 13f79535-47bb-0310-9956-ffa450edef68 --- qpid/cpp/src/Makefile.am | 2 +- qpid/cpp/src/qpid/DataDir.h | 4 +-- qpid/cpp/src/qpid/acl/Acl.cpp | 42 +++++++++++------------ qpid/cpp/src/qpid/acl/Acl.h | 4 +-- qpid/cpp/src/qpid/acl/management-schema.xml | 2 +- qpid/cpp/src/qpid/broker/Bridge.cpp | 12 ++++--- qpid/cpp/src/qpid/broker/Bridge.h | 11 +++--- qpid/cpp/src/qpid/broker/Broker.cpp | 18 +++++----- qpid/cpp/src/qpid/broker/Broker.h | 6 ++-- qpid/cpp/src/qpid/broker/Connection.cpp | 5 +-- qpid/cpp/src/qpid/broker/Connection.h | 4 +-- qpid/cpp/src/qpid/broker/DirectExchange.cpp | 5 +-- qpid/cpp/src/qpid/broker/Exchange.cpp | 8 +++-- qpid/cpp/src/qpid/broker/Exchange.h | 8 ++--- qpid/cpp/src/qpid/broker/FanOutExchange.cpp | 5 +-- qpid/cpp/src/qpid/broker/HeadersExchange.cpp | 5 +-- qpid/cpp/src/qpid/broker/Link.cpp | 10 +++--- qpid/cpp/src/qpid/broker/Link.h | 4 +-- qpid/cpp/src/qpid/broker/LinkRegistry.cpp | 3 +- qpid/cpp/src/qpid/broker/Queue.cpp | 9 ++--- qpid/cpp/src/qpid/broker/Queue.h | 4 +-- qpid/cpp/src/qpid/broker/SessionState.cpp | 15 ++++---- qpid/cpp/src/qpid/broker/SessionState.h | 4 +-- qpid/cpp/src/qpid/broker/System.cpp | 3 +- qpid/cpp/src/qpid/broker/System.h | 4 +-- qpid/cpp/src/qpid/broker/TopicExchange.cpp | 5 +-- qpid/cpp/src/qpid/broker/Vhost.cpp | 3 +- qpid/cpp/src/qpid/broker/Vhost.h | 4 +-- qpid/cpp/src/qpid/broker/XmlExchange.cpp | 5 +-- qpid/cpp/src/qpid/management/ManagementBroker.cpp | 16 +++++---- qpid/cpp/src/qpid/management/ManagementBroker.h | 32 ++++++++--------- 31 files changed, 139 insertions(+), 123 deletions(-) (limited to 'qpid/cpp/src') diff --git a/qpid/cpp/src/Makefile.am b/qpid/cpp/src/Makefile.am index 9b391a907f..9bef06e7bb 100644 --- a/qpid/cpp/src/Makefile.am +++ b/qpid/cpp/src/Makefile.am @@ -28,7 +28,7 @@ $(rgen_generator): # Management generator. mgen_dir=$(top_srcdir)/managementgen -mgen_cmd=$(mgen_dir)/qmf-gen -m $(srcdir)/managementgen.mk -o gen/qpid/management \ +mgen_cmd=$(mgen_dir)/qmf-gen -m $(srcdir)/managementgen.mk -o gen/qmf \ $(top_srcdir)/../specs/management-schema.xml \ $(srcdir)/qpid/acl/management-schema.xml diff --git a/qpid/cpp/src/qpid/DataDir.h b/qpid/cpp/src/qpid/DataDir.h index 7de5ebf62d..6b45d8747b 100644 --- a/qpid/cpp/src/qpid/DataDir.h +++ b/qpid/cpp/src/qpid/DataDir.h @@ -41,8 +41,8 @@ class DataDir DataDir (std::string path); ~DataDir (); - bool isEnabled () { return enabled; } - std::string getPath () { return dirPath; } + bool isEnabled() { return enabled; } + const std::string& getPath() { return dirPath; } }; } // namespace qpid diff --git a/qpid/cpp/src/qpid/acl/Acl.cpp b/qpid/cpp/src/qpid/acl/Acl.cpp index f9c307c7d3..0a793c88e0 100644 --- a/qpid/cpp/src/qpid/acl/Acl.cpp +++ b/qpid/cpp/src/qpid/acl/Acl.cpp @@ -24,39 +24,38 @@ #include "qpid/Options.h" #include "qpid/shared_ptr.h" #include "qpid/log/Logger.h" -#include "qpid/management/PackageACL.h" +#include "qmf/org/apache/qpid/acl/Package.h" #include #include -namespace qpid { -namespace acl { - using namespace std; +using namespace qpid::acl; using qpid::management::ManagementAgent; using qpid::management::ManagementObject; using qpid::management::Manageable; using qpid::management::Args; +namespace _qmf = qmf::org::apache::qpid::acl; - Acl::Acl (AclValues& av, broker::Broker& b): aclValues(av), broker(&b), transferAcl(false) - { +Acl::Acl (AclValues& av, broker::Broker& b): aclValues(av), broker(&b), transferAcl(false) +{ - ManagementAgent* agent = ManagementAgent::Singleton::getInstance(); - - if (agent != 0){ - management::PackageACL packageInit(agent); - mgmtObject = new management::Acl (agent, this, broker); - agent->addObject (mgmtObject); - } - - if (!readAclFile()){ - throw Exception("Could not read ACL file"); - if (mgmtObject!=0) mgmtObject->set_enforcingAcl(0); - } - QPID_LOG(info, "ACL Plugin loaded"); + ManagementAgent* agent = ManagementAgent::Singleton::getInstance(); + + if (agent != 0){ + _qmf::Package packageInit(agent); + mgmtObject = new _qmf::Acl (agent, this, broker); + agent->addObject (mgmtObject); + } + + if (!readAclFile()){ + throw Exception("Could not read ACL file"); + if (mgmtObject!=0) mgmtObject->set_enforcingAcl(0); + } + QPID_LOG(info, "ACL Plugin loaded"); if (mgmtObject!=0) mgmtObject->set_enforcingAcl(1); - } +} bool Acl::authorise(const std::string& id, const Action& action, const ObjectType& objType, const std::string& name, std::map* params) { @@ -147,7 +146,7 @@ using qpid::management::Args; switch (methodId) { - case management::Acl::METHOD_RELOADACLFILE : + case _qmf::Acl::METHOD_RELOADACLFILE : readAclFile(); status = Manageable::STATUS_OK; break; @@ -155,4 +154,3 @@ using qpid::management::Args; return status; } -}} // namespace qpid::acl diff --git a/qpid/cpp/src/qpid/acl/Acl.h b/qpid/cpp/src/qpid/acl/Acl.h index 22450709d9..b072d24cc0 100644 --- a/qpid/cpp/src/qpid/acl/Acl.h +++ b/qpid/cpp/src/qpid/acl/Acl.h @@ -27,7 +27,7 @@ #include "qpid/RefCounted.h" #include "qpid/broker/AclModule.h" #include "qpid/management/Manageable.h" -#include "qpid/management/Acl.h" +#include "qmf/org/apache/qpid/acl/Acl.h" #include #include @@ -56,7 +56,7 @@ private: broker::Broker* broker; bool transferAcl; boost::shared_ptr data; - management::Acl* mgmtObject; // mgnt owns lifecycle + qmf::org::apache::qpid::acl::Acl* mgmtObject; // mgnt owns lifecycle public: diff --git a/qpid/cpp/src/qpid/acl/management-schema.xml b/qpid/cpp/src/qpid/acl/management-schema.xml index ebd1eb2a53..7d20353755 100644 --- a/qpid/cpp/src/qpid/acl/management-schema.xml +++ b/qpid/cpp/src/qpid/acl/management-schema.xml @@ -1,4 +1,4 @@ - +