From 14834d9bb1d6142d56a37621e98719f1a455a6aa Mon Sep 17 00:00:00 2001 From: "Charles E. Rolke" Date: Sat, 3 Nov 2012 10:21:59 +0000 Subject: QPID-4403 review 7810 Too many 'task late and overran' messages Demote TimerWarning messages to debug level. Print them only once per minute. To enable only these messages when broker is otherwise at INFO log level: --log-enable debug+:Timer git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1405316 13f79535-47bb-0310-9956-ffa450edef68 --- qpid/cpp/src/qpid/sys/Timer.cpp | 6 +++--- qpid/cpp/src/qpid/sys/TimerWarnings.cpp | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'qpid/cpp/src') diff --git a/qpid/cpp/src/qpid/sys/Timer.cpp b/qpid/cpp/src/qpid/sys/Timer.cpp index 973c6bd8b7..83d1a5260b 100644 --- a/qpid/cpp/src/qpid/sys/Timer.cpp +++ b/qpid/cpp/src/qpid/sys/Timer.cpp @@ -107,7 +107,7 @@ Timer::Timer() : late(50 * TIME_MSEC), overran(2 * TIME_MSEC), lateCancel(500 * TIME_MSEC), - warn(5 * TIME_SEC) + warn(60 * TIME_SEC) { start(); } @@ -171,8 +171,8 @@ void Timer::run() if (!tasks.empty()) { overrun = Duration(tasks.top()->nextFireTime, end); } - bool warningsEnabled; - QPID_LOG_TEST(warning, warningsEnabled); + bool warningsEnabled; // TimerWarning enabled + QPID_LOG_TEST(debug, warningsEnabled); // TimerWarning emitted at debug level if (warningsEnabled) { if (overrun > overran) { if (delay > overran) // if delay is significant to an overrun. diff --git a/qpid/cpp/src/qpid/sys/TimerWarnings.cpp b/qpid/cpp/src/qpid/sys/TimerWarnings.cpp index 85e26da54a..00fb0d9db6 100644 --- a/qpid/cpp/src/qpid/sys/TimerWarnings.cpp +++ b/qpid/cpp/src/qpid/sys/TimerWarnings.cpp @@ -56,18 +56,18 @@ void TimerWarnings::log() { std::string task = i->first; TaskStats& stats = i->second; if (stats.lateDelay.count) - QPID_LOG(info, task << " task late " + QPID_LOG(debug, task << " task late " << stats.lateDelay.count << " times by " << stats.lateDelay.average()/TIME_MSEC << "ms on average."); if (stats.overranOverrun.count) - QPID_LOG(info, task << " task overran " + QPID_LOG(debug, task << " task overran " << stats.overranOverrun.count << " times by " << stats.overranOverrun.average()/TIME_MSEC << "ms (taking " << stats.overranTime.average() << "ns) on average."); if (stats.lateAndOverranOverrun.count) - QPID_LOG(info, task << " task late and overran " + QPID_LOG(debug, task << " task late and overran " << stats.lateAndOverranOverrun.count << " times: late " << stats.lateAndOverranDelay.average()/TIME_MSEC << "ms, overran " << stats.lateAndOverranOverrun.average()/TIME_MSEC << "ms (taking " -- cgit v1.2.1