From 98b05fa63abcac4fe4ba265c9639e6b74b0b7a41 Mon Sep 17 00:00:00 2001 From: Martin Ritchie Date: Fri, 28 Sep 2007 09:04:03 +0000 Subject: QPID-597 : TopicSessionTest Failure, Patch supplied by Aidan Skinner. ResetMessageListenerTest.java was changing the prefetch method via a system property that propogated to all tests. git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/branches/M2.1@580258 13f79535-47bb-0310-9956-ffa450edef68 --- .../qpid/client/ResetMessageListenerTest.java | 23 ++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) (limited to 'java/client/src') diff --git a/java/client/src/test/java/org/apache/qpid/client/ResetMessageListenerTest.java b/java/client/src/test/java/org/apache/qpid/client/ResetMessageListenerTest.java index 5f7ca69554..28320d923a 100644 --- a/java/client/src/test/java/org/apache/qpid/client/ResetMessageListenerTest.java +++ b/java/client/src/test/java/org/apache/qpid/client/ResetMessageListenerTest.java @@ -72,11 +72,14 @@ public class ResetMessageListenerTest extends TestCase private final CountDownLatch _allFirstMessagesSent = new CountDownLatch(2); // all messages Sent Lock private final CountDownLatch _allSecondMessagesSent = new CountDownLatch(2); // all messages Sent Lock + private String oldImmediatePrefetch; + protected void setUp() throws Exception { super.setUp(); TransportConnection.createVMBroker(1); + oldImmediatePrefetch = System.getProperty(AMQSession.IMMEDIATE_PREFETCH); System.setProperty(AMQSession.IMMEDIATE_PREFETCH, "true"); InitialContextFactory factory = new PropertiesFileInitialContextFactory(); @@ -117,17 +120,16 @@ public class ResetMessageListenerTest extends TestCase } protected void tearDown() throws Exception - { - assertEquals("First batch of messages not received correctly", 0, _allFirstMessagesSent.getCount()); - assertEquals("Second batch of messages not received correctly", 0, _allSecondMessagesSent.getCount()); - assertEquals("Client 1 ML1 didn't get all messages", MSG_COUNT / 2, receivedCount1ML1); - assertEquals("Client 2 didn't get all messages", MSG_COUNT, receivedCount2); - assertEquals("Client 1 ML2 didn't get all messages", MSG_COUNT / 2, receivedCount1ML2); - + { _clientConnection.close(); - _producerConnection.close(); + super.tearDown(); + if (oldImmediatePrefetch == null) + { + oldImmediatePrefetch = AMQSession.IMMEDIATE_PREFETCH_DEFAULT; + } + System.setProperty(AMQSession.IMMEDIATE_PREFETCH, oldImmediatePrefetch); TransportConnection.killAllVMBrokers(); } @@ -261,6 +263,11 @@ public class ResetMessageListenerTest extends TestCase { // do nothing } + assertEquals("First batch of messages not received correctly", 0, _allFirstMessagesSent.getCount()); + assertEquals("Second batch of messages not received correctly", 0, _allSecondMessagesSent.getCount()); + assertEquals("Client 1 ML1 didn't get all messages", MSG_COUNT / 2, receivedCount1ML1); + assertEquals("Client 2 didn't get all messages", MSG_COUNT, receivedCount2); + assertEquals("Client 1 ML2 didn't get all messages", MSG_COUNT / 2, receivedCount1ML2); } public static junit.framework.Test suite() -- cgit v1.2.1