From 9a6441eb8b76af354562fa1b9a260bc79011a182 Mon Sep 17 00:00:00 2001 From: Alex Rudyy Date: Fri, 17 May 2013 15:26:04 +0000 Subject: QPID-4863: Validate plugin attribute changes and throw UnsupportedOperationException where attribute changes are not supported git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@1483861 13f79535-47bb-0310-9956-ffa450edef68 --- .../server/model/adapter/ConnectionAdapter.java | 14 +++++++++++ .../qpid/server/model/adapter/ConsumerAdapter.java | 14 +++++++++++ .../server/model/adapter/GroupProviderAdapter.java | 27 ++++++++++++++++++++++ .../qpid/server/model/adapter/SessionAdapter.java | 14 +++++++++++ 4 files changed, 69 insertions(+) (limited to 'java/broker') diff --git a/java/broker/src/main/java/org/apache/qpid/server/model/adapter/ConnectionAdapter.java b/java/broker/src/main/java/org/apache/qpid/server/model/adapter/ConnectionAdapter.java index 54a3b634e5..aaa6f460d2 100644 --- a/java/broker/src/main/java/org/apache/qpid/server/model/adapter/ConnectionAdapter.java +++ b/java/broker/src/main/java/org/apache/qpid/server/model/adapter/ConnectionAdapter.java @@ -305,4 +305,18 @@ final class ConnectionAdapter extends AbstractAdapter implements Connection // TODO: add state management return false; } + + @Override + public Object setAttribute(final String name, final Object expected, final Object desired) throws IllegalStateException, + AccessControlException, IllegalArgumentException + { + throw new UnsupportedOperationException("Changing attributes on connection is not supported."); + } + + @Override + public void setAttributes(final Map attributes) throws IllegalStateException, AccessControlException, + IllegalArgumentException + { + throw new UnsupportedOperationException("Changing attributes on connection is not supported."); + } } diff --git a/java/broker/src/main/java/org/apache/qpid/server/model/adapter/ConsumerAdapter.java b/java/broker/src/main/java/org/apache/qpid/server/model/adapter/ConsumerAdapter.java index 4633605256..696c59783e 100644 --- a/java/broker/src/main/java/org/apache/qpid/server/model/adapter/ConsumerAdapter.java +++ b/java/broker/src/main/java/org/apache/qpid/server/model/adapter/ConsumerAdapter.java @@ -225,4 +225,18 @@ public class ConsumerAdapter extends AbstractAdapter implements Consumer // TODO : Add state management return false; } + + @Override + public Object setAttribute(final String name, final Object expected, final Object desired) throws IllegalStateException, + AccessControlException, IllegalArgumentException + { + throw new UnsupportedOperationException("Changing attributes on consumer is not supported."); + } + + @Override + public void setAttributes(final Map attributes) throws IllegalStateException, AccessControlException, + IllegalArgumentException + { + throw new UnsupportedOperationException("Changing attributes on consumer is not supported."); + } } diff --git a/java/broker/src/main/java/org/apache/qpid/server/model/adapter/GroupProviderAdapter.java b/java/broker/src/main/java/org/apache/qpid/server/model/adapter/GroupProviderAdapter.java index 3bf62dc96b..9323606c83 100644 --- a/java/broker/src/main/java/org/apache/qpid/server/model/adapter/GroupProviderAdapter.java +++ b/java/broker/src/main/java/org/apache/qpid/server/model/adapter/GroupProviderAdapter.java @@ -544,6 +544,20 @@ public class GroupProviderAdapter extends AbstractAdapter implements return false; } + @Override + public Object setAttribute(final String name, final Object expected, final Object desired) throws IllegalStateException, + AccessControlException, IllegalArgumentException + { + throw new UnsupportedOperationException("Changing attributes on group is not supported."); + } + + @Override + public void setAttributes(final Map attributes) throws IllegalStateException, AccessControlException, + IllegalArgumentException + { + throw new UnsupportedOperationException("Changing attributes on group is not supported."); + } + private class GroupMemberAdapter extends AbstractAdapter implements GroupMember { @@ -676,6 +690,19 @@ public class GroupProviderAdapter extends AbstractAdapter implements return false; } + @Override + public Object setAttribute(final String name, final Object expected, final Object desired) throws IllegalStateException, + AccessControlException, IllegalArgumentException + { + throw new UnsupportedOperationException("Changing attributes on group member is not supported."); + } + + @Override + public void setAttributes(final Map attributes) throws IllegalStateException, AccessControlException, + IllegalArgumentException + { + throw new UnsupportedOperationException("Changing attributes on group member is not supported."); + } } } diff --git a/java/broker/src/main/java/org/apache/qpid/server/model/adapter/SessionAdapter.java b/java/broker/src/main/java/org/apache/qpid/server/model/adapter/SessionAdapter.java index 550e8cecd6..31ce7e56fd 100644 --- a/java/broker/src/main/java/org/apache/qpid/server/model/adapter/SessionAdapter.java +++ b/java/broker/src/main/java/org/apache/qpid/server/model/adapter/SessionAdapter.java @@ -276,4 +276,18 @@ final class SessionAdapter extends AbstractAdapter implements Session // TODO : add state management return false; } + + @Override + public Object setAttribute(final String name, final Object expected, final Object desired) throws IllegalStateException, + AccessControlException, IllegalArgumentException + { + throw new UnsupportedOperationException("Changing attributes on session is not supported."); + } + + @Override + public void setAttributes(final Map attributes) throws IllegalStateException, AccessControlException, + IllegalArgumentException + { + throw new UnsupportedOperationException("Changing attributes on session is not supported."); + } } -- cgit v1.2.1