From 3d3fb015b49b088a6e1f641437cd6b7acb0ed6ec Mon Sep 17 00:00:00 2001
From: Andrew Stitcher <astitcher@apache.org>
Date: Tue, 22 Sep 2009 15:59:53 +0000
Subject: Make the AsynchIO API more consistent

git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@817711 13f79535-47bb-0310-9956-ffa450edef68
---
 cpp/src/qpid/sys/AsynchIOHandler.cpp | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

(limited to 'cpp/src/qpid/sys/AsynchIOHandler.cpp')

diff --git a/cpp/src/qpid/sys/AsynchIOHandler.cpp b/cpp/src/qpid/sys/AsynchIOHandler.cpp
index 46d8f3b4f1..ae41eacfc3 100644
--- a/cpp/src/qpid/sys/AsynchIOHandler.cpp
+++ b/cpp/src/qpid/sys/AsynchIOHandler.cpp
@@ -103,13 +103,11 @@ void AsynchIOHandler::giveReadCredit(int32_t credit) {
         aio->startReading();
 }
 
-bool AsynchIOHandler::readbuff(AsynchIO& , AsynchIO::BufferBase* buff) {
+void AsynchIOHandler::readbuff(AsynchIO& , AsynchIO::BufferBase* buff) {
     if (readError) {
-        return false;
+        return;
     }
 
-    bool ret = true;
-
     // Check here for read credit
     if (readCredit.get() != InfiniteCredit) {
         // TODO In theory should be able to use an atomic operation before taking the lock
@@ -119,7 +117,6 @@ bool AsynchIOHandler::readbuff(AsynchIO& , AsynchIO::BufferBase* buff) {
             assert(readCredit.get() >= 0);
             if (readCredit.get() == 0) {
                 aio->stopReading();
-                ret = false;
             }
         }
     }
@@ -166,7 +163,6 @@ bool AsynchIOHandler::readbuff(AsynchIO& , AsynchIO::BufferBase* buff) {
         // Give whole buffer back to aio subsystem
         aio->queueReadBuffer(buff);
     }
-    return ret;
 }
 
 void AsynchIOHandler::eof(AsynchIO&) {
-- 
cgit v1.2.1