From 05e723db5178fd7d49de3ec19e8b0bb28871a988 Mon Sep 17 00:00:00 2001 From: Radu Ciorba Date: Tue, 31 Mar 2015 22:43:26 +0300 Subject: fix indentation, add changelog entry --- CONTRIBUTORS.txt | 2 +- ChangeLog | 3 +++ pylint/checkers/variables.py | 4 ++-- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt index f24bad0..5414fad 100644 --- a/CONTRIBUTORS.txt +++ b/CONTRIBUTORS.txt @@ -56,7 +56,7 @@ Order doesn't matter (not that much, at least ;) * Steven Myint: duplicate-except. -* Radu Ciorbă: not-context-manager and confusing-with-statement warnings. +* Radu Ciorba: not-context-manager and confusing-with-statement warnings. * Wolfgang Grafen, Axel Muller, Fabio Zadrozny, Pierre Rouleau, Maarten ter Huurne, Mirko Friedenhagen and all the Logilab's team (among others): diff --git a/ChangeLog b/ChangeLog index 570a26c..422f2e6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -2,6 +2,9 @@ ChangeLog for Pylint -------------------- -- + * Fix unused-import false positive when the import is used in a + class assignment. Closes issue #475 + * Add a new error, 'not-context-manager', emitted when something that doesn't implement __enter__ and __exit__ is used in a with statement. diff --git a/pylint/checkers/variables.py b/pylint/checkers/variables.py index db99e97..8653d54 100644 --- a/pylint/checkers/variables.py +++ b/pylint/checkers/variables.py @@ -792,8 +792,8 @@ builtins. Remember that you should avoid to define new builtins when possible.' # mark the name as consumed if it's defined in this scope found_node = to_consume.get(name) if (found_node - and isinstance(node.parent, astroid.Assign) - and node.parent == found_node[0].parent): + and isinstance(node.parent, astroid.Assign) + and node.parent == found_node[0].parent): lhs = found_node[0].parent.targets[0] if lhs.name == name: # this name is defined in this very statement found_node = None -- cgit v1.2.1