From a13131627c67db9e422c203f391a74b3ca7315a8 Mon Sep 17 00:00:00 2001 From: Danny Sepler Date: Mon, 31 Oct 2022 22:44:15 -0400 Subject: Fix false positive with E741 --- pycodestyle.py | 3 ++- testsuite/python38.py | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/pycodestyle.py b/pycodestyle.py index 29f93ea..a105a0f 100755 --- a/pycodestyle.py +++ b/pycodestyle.py @@ -1504,6 +1504,7 @@ def ambiguous_identifier(logical_line, tokens): Okay: lambda arg: arg * l Okay: lambda a=l[I:5]: None Okay: lambda x=a.I: None + Okay: if l >= 12: E741: except AttributeError as O: E741: with lock as l: E741: global I @@ -1542,7 +1543,7 @@ def ambiguous_identifier(logical_line, tokens): elif text == ')': parameter_parentheses_level -= 1 # identifiers on the lhs of an assignment operator - if token_type == tokenize.OP and '=' in text and \ + if token_type == tokenize.OP and text in {'=', ':='} and \ parameter_parentheses_level == 0: if prev_text in idents_to_avoid: ident = prev_text diff --git a/testsuite/python38.py b/testsuite/python38.py index 8bf0d4d..faf9aa7 100644 --- a/testsuite/python38.py +++ b/testsuite/python38.py @@ -53,3 +53,6 @@ if x := 2: #: E221:1:6 E221:1:19 if (x := 1) == (y := 2): pass +#: E741 +while l := 1: + pass -- cgit v1.2.1