From 0705bde8c0b6f723d6c75b9f029725a325ac461c Mon Sep 17 00:00:00 2001 From: Bas van Beek <43369155+BvB93@users.noreply.github.com> Date: Wed, 23 Feb 2022 16:11:59 +0100 Subject: MAINT: Remove a leftover `__array_finalize__` property decorator --- numpy/typing/tests/data/fail/ndarray_misc.pyi | 2 ++ numpy/typing/tests/data/reveal/ndarray_misc.pyi | 4 ++++ 2 files changed, 6 insertions(+) (limited to 'numpy/typing') diff --git a/numpy/typing/tests/data/fail/ndarray_misc.pyi b/numpy/typing/tests/data/fail/ndarray_misc.pyi index 8320a44f3..77bd9a44e 100644 --- a/numpy/typing/tests/data/fail/ndarray_misc.pyi +++ b/numpy/typing/tests/data/fail/ndarray_misc.pyi @@ -39,3 +39,5 @@ AR_b.__index__() # E: Invalid self argument AR_f8[1.5] # E: No overload variant AR_f8["field_a"] # E: No overload variant AR_f8[["field_a", "field_b"]] # E: Invalid index type + +AR_f8.__array_finalize__(object()) # E: incompatible type diff --git a/numpy/typing/tests/data/reveal/ndarray_misc.pyi b/numpy/typing/tests/data/reveal/ndarray_misc.pyi index f91d6351b..c9a42b3e8 100644 --- a/numpy/typing/tests/data/reveal/ndarray_misc.pyi +++ b/numpy/typing/tests/data/reveal/ndarray_misc.pyi @@ -212,3 +212,7 @@ reveal_type(AR_f8.dump("test_file")) # E: None reveal_type(AR_f8.dump(b"test_file")) # E: None with open("test_file", "wb") as f: reveal_type(AR_f8.dump(f)) # E: None + +reveal_type(AR_f8.__array_finalize__(None)) # E: None +reveal_type(AR_f8.__array_finalize__(B)) # E: None +reveal_type(AR_f8.__array_finalize__(AR_f8)) # E: None -- cgit v1.2.1 From 370b404d9652ab1f4086f2726ed63a9e0e013029 Mon Sep 17 00:00:00 2001 From: Bas van Beek <43369155+BvB93@users.noreply.github.com> Date: Wed, 23 Feb 2022 16:12:59 +0100 Subject: MAINT: Relax the `obj` type in `__array_finalize__` --- numpy/typing/tests/data/reveal/chararray.pyi | 3 +++ numpy/typing/tests/data/reveal/memmap.pyi | 2 ++ numpy/typing/tests/data/reveal/rec.pyi | 1 + 3 files changed, 6 insertions(+) (limited to 'numpy/typing') diff --git a/numpy/typing/tests/data/reveal/chararray.pyi b/numpy/typing/tests/data/reveal/chararray.pyi index 3da2e1599..61906c860 100644 --- a/numpy/typing/tests/data/reveal/chararray.pyi +++ b/numpy/typing/tests/data/reveal/chararray.pyi @@ -127,3 +127,6 @@ reveal_type(AR_S.istitle()) # E: ndarray[Any, dtype[bool_]] reveal_type(AR_U.isupper()) # E: ndarray[Any, dtype[bool_]] reveal_type(AR_S.isupper()) # E: ndarray[Any, dtype[bool_]] + +reveal_type(AR_U.__array_finalize__(object())) # E: None +reveal_type(AR_S.__array_finalize__(object())) # E: None diff --git a/numpy/typing/tests/data/reveal/memmap.pyi b/numpy/typing/tests/data/reveal/memmap.pyi index 86de8eb08..af7307499 100644 --- a/numpy/typing/tests/data/reveal/memmap.pyi +++ b/numpy/typing/tests/data/reveal/memmap.pyi @@ -14,3 +14,5 @@ reveal_type(np.memmap("file.txt", offset=5)) # E: memmap[Any, dtype[{uint8}]] reveal_type(np.memmap(b"file.txt", dtype=np.float64, shape=(10, 3))) # E: memmap[Any, dtype[{float64}]] with open("file.txt", "rb") as f: reveal_type(np.memmap(f, dtype=float, order="K")) # E: memmap[Any, dtype[Any]] + +reveal_type(memmap_obj.__array_finalize__(object())) # E: None diff --git a/numpy/typing/tests/data/reveal/rec.pyi b/numpy/typing/tests/data/reveal/rec.pyi index b2eaca899..8ea4a6ee8 100644 --- a/numpy/typing/tests/data/reveal/rec.pyi +++ b/numpy/typing/tests/data/reveal/rec.pyi @@ -33,6 +33,7 @@ reveal_type(REC_AR_V.field(0, AR_i8)) # E: None reveal_type(REC_AR_V.field("field_a", AR_i8)) # E: None reveal_type(REC_AR_V["field_a"]) # E: Any reveal_type(REC_AR_V.field_a) # E: Any +reveal_type(REC_AR_V.__array_finalize__(object())) # E: None reveal_type(np.recarray( # recarray[Any, dtype[record]] shape=(10, 5), -- cgit v1.2.1