From 890c0cfe15f0e3325b57e44f9b9a9f78f9797f25 Mon Sep 17 00:00:00 2001 From: Ralf Gommers Date: Tue, 4 Jan 2022 08:17:10 +0100 Subject: TYP: accept review comment on ignoring NotImplemented in type checking Co-authored-by: Bas van Beek <43369155+BvB93@users.noreply.github.com> --- numpy/array_api/_array_object.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'numpy/array_api/_array_object.py') diff --git a/numpy/array_api/_array_object.py b/numpy/array_api/_array_object.py index 900a0ae1e..93ae10603 100644 --- a/numpy/array_api/_array_object.py +++ b/numpy/array_api/_array_object.py @@ -125,10 +125,7 @@ class Array: # spec in places where it either deviates from or is more strict than # NumPy behavior - # NOTE: no valid type annotation possible. E.g `Union[Array, - # NotImplemented]` is forbidden, see https://github.com/python/mypy/issues/363 - # Maybe change returned object to `Literal['NotImplemented']`? - def _check_allowed_dtypes(self, other, dtype_category, op): + def _check_allowed_dtypes(self, other: bool | int | float | Array, dtype_category: str, op: str) -> Array: """ Helper function for operators to only allow specific input dtypes -- cgit v1.2.1