From 11cf3973bfc64ab0b4e471fc56dae911df1ec8d9 Mon Sep 17 00:00:00 2001 From: Jeff Widman Date: Thu, 10 May 2018 16:12:19 -0700 Subject: Stop shadowing `ConnectionError` In Python3, `ConnectionError` is a native exception. So rename our custom one to `KafkaConnectionError` to prevent accidentally shadowing the native one. Note that there are still valid uses of `ConnectionError` in this code. They already expect a native Python3 `ConnectionError`, and also already handle the Python2 compatibility issues. --- kafka/errors.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'kafka/errors.py') diff --git a/kafka/errors.py b/kafka/errors.py index c70853c..f4c8740 100644 --- a/kafka/errors.py +++ b/kafka/errors.py @@ -447,7 +447,7 @@ class FailedPayloadsError(KafkaError): self.payload = payload -class ConnectionError(KafkaError): +class KafkaConnectionError(KafkaError): retriable = True invalid_metadata = True @@ -517,13 +517,13 @@ def check_error(response): RETRY_BACKOFF_ERROR_TYPES = ( KafkaUnavailableError, LeaderNotAvailableError, - ConnectionError, FailedPayloadsError + KafkaConnectionError, FailedPayloadsError ) RETRY_REFRESH_ERROR_TYPES = ( NotLeaderForPartitionError, UnknownTopicOrPartitionError, - LeaderNotAvailableError, ConnectionError + LeaderNotAvailableError, KafkaConnectionError ) -- cgit v1.2.1