From 2c4b9cdf2cc18ccd40d2489e74766c6b702c2725 Mon Sep 17 00:00:00 2001
From: Dana Powers <dana.powers@gmail.com>
Date: Sat, 16 Jul 2016 10:29:37 -0700
Subject: Add api_version config to KafkaClient, deprecate str in favor of
 tuples

---
 kafka/conn.py | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

(limited to 'kafka/conn.py')

diff --git a/kafka/conn.py b/kafka/conn.py
index 0418bc5..6028867 100644
--- a/kafka/conn.py
+++ b/kafka/conn.py
@@ -541,7 +541,12 @@ class BrokerConnection(object):
         return self._correlation_id
 
     def check_version(self, timeout=2, strict=False):
-        """Attempt to guess the broker version. This is a blocking call."""
+        """Attempt to guess the broker version.
+
+        Note: This is a blocking call.
+
+        Returns: version tuple, i.e. (0, 10), (0, 9), (0, 8, 2), ...
+        """
 
         # Monkeypatch the connection request timeout
         # Generally this timeout should not get triggered
@@ -643,7 +648,7 @@ class BrokerConnection(object):
 
         log.removeFilter(log_filter)
         self.config['request_timeout_ms'] = stashed_request_timeout_ms
-        return version
+        return tuple(map(int, version.split('.')))
 
     def __repr__(self):
         return "<BrokerConnection host=%s/%s port=%d>" % (self.hostname, self.host,
-- 
cgit v1.2.1