From 52eae4a14268a57786eabd26b2022163dc5dc5e5 Mon Sep 17 00:00:00 2001
From: Dana Powers <dana.powers@gmail.com>
Date: Thu, 8 Feb 2018 09:40:49 -0800
Subject: Fix pending completion IndexError bug caused by multiple threads

---
 kafka/client_async.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

(limited to 'kafka/client_async.py')

diff --git a/kafka/client_async.py b/kafka/client_async.py
index 4962d9f..24a5bef 100644
--- a/kafka/client_async.py
+++ b/kafka/client_async.py
@@ -665,8 +665,14 @@ class KafkaClient(object):
 
     def _fire_pending_completed_requests(self):
         responses = []
-        while self._pending_completion:
-            response, future = self._pending_completion.popleft()
+        while True:
+            try:
+                # We rely on deque.popleft remaining threadsafe
+                # to allow both the heartbeat thread and the main thread
+                # to process responses
+                response, future = self._pending_completion.popleft()
+            except IndexError:
+                break
             future.success(response)
             responses.append(response)
         return responses
-- 
cgit v1.2.1