From 31ee4ed2af6da77bf4ad84589e7cc7d6272b40be Mon Sep 17 00:00:00 2001 From: Dana Powers Date: Sun, 6 Dec 2015 12:18:22 -0800 Subject: Log deprecation warning for timeout argument in Producer.stop() --- kafka/producer/base.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/kafka/producer/base.py b/kafka/producer/base.py index 1ba4f5b..39b1f84 100644 --- a/kafka/producer/base.py +++ b/kafka/producer/base.py @@ -415,16 +415,20 @@ class Producer(object): raise return resp - def stop(self): + def stop(self, timeout=None): """ Stop the producer (async mode). Blocks until async thread completes. """ + if timeout is not None: + log.warning('timeout argument to stop() is deprecated - ' + 'it will be removed in future release') + if not self.async: - log.warning("producer.stop() called, but producer is not async") + log.warning('producer.stop() called, but producer is not async') return if self.stopped: - log.warning("producer.stop() called, but producer is already stopped") + log.warning('producer.stop() called, but producer is already stopped') return if self.async: -- cgit v1.2.1