<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/python-packages/kafka-python.git/test, branch simplify-version-checking-using-pytest-skipif</title>
<subtitle>github.com: mumrah/kafka-python.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/'/>
<entry>
<title>Cleanup handling of KAFKA_VERSION env var in tests</title>
<updated>2019-08-22T08:25:45+00:00</updated>
<author>
<name>Jeff Widman</name>
<email>jeff@jeffwidman.com</email>
</author>
<published>2019-08-22T08:15:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=bc87474632637dee3e09a878f91ee6ff38e3a8bd'/>
<id>bc87474632637dee3e09a878f91ee6ff38e3a8bd</id>
<content type='text'>
Now that we are using `pytest`, there is no need for a custom decorator
because we can use `pytest.mark.skipif()`.

This makes the code significantly simpler. In particular, dropping the
custom `@kafka_versions()` decorator is necessary because it uses
`func.wraps()` which doesn't play nice with `pytest` fixtures:
- https://github.com/pytest-dev/pytest/issues/677
- https://stackoverflow.com/a/19614807/770425

So this is a pre-requisite to migrating some of those tests to using
pytest fixtures.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now that we are using `pytest`, there is no need for a custom decorator
because we can use `pytest.mark.skipif()`.

This makes the code significantly simpler. In particular, dropping the
custom `@kafka_versions()` decorator is necessary because it uses
`func.wraps()` which doesn't play nice with `pytest` fixtures:
- https://github.com/pytest-dev/pytest/issues/677
- https://stackoverflow.com/a/19614807/770425

So this is a pre-requisite to migrating some of those tests to using
pytest fixtures.
</pre>
</div>
</content>
</entry>
<entry>
<title>Minor test cleanup (#1885)</title>
<updated>2019-08-22T01:47:22+00:00</updated>
<author>
<name>Jeff Widman</name>
<email>jeff@jeffwidman.com</email>
</author>
<published>2019-08-22T01:47:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=e49caeb3ebdd36eb4d18a517bc402f8e89dfdbee'/>
<id>e49caeb3ebdd36eb4d18a517bc402f8e89dfdbee</id>
<content type='text'>
Remove unused import, whitespace, etc. No functional changes, just
cleaning it up so the diffs of later changes are cleaner.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove unused import, whitespace, etc. No functional changes, just
cleaning it up so the diffs of later changes are cleaner.</pre>
</div>
</content>
</entry>
<entry>
<title>tests: Use socket.SOCK_STREAM in assertions</title>
<updated>2019-08-15T18:36:05+00:00</updated>
<author>
<name>Ivan A. Melnikov</name>
<email>iv@altlinux.org</email>
</author>
<published>2019-08-12T07:42:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=2180d312c36e62c7175c112b38cbde79c3c90377'/>
<id>2180d312c36e62c7175c112b38cbde79c3c90377</id>
<content type='text'>
socket.SOCK_STREAM is platform specific and on some
platforms (most notably on Linux on MIPS) does not
equal 1; so it's better to use the constant where
appropriate.

This change fixes the tests on my MIPS32 LE machine.

Signed-off-by: Ivan A. Melnikov &lt;iv@altlinux.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
socket.SOCK_STREAM is platform specific and on some
platforms (most notably on Linux on MIPS) does not
equal 1; so it's better to use the constant where
appropriate.

This change fixes the tests on my MIPS32 LE machine.

Signed-off-by: Ivan A. Melnikov &lt;iv@altlinux.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Sanity test for consumer.topics() and consumer.partitions_for_topic()</title>
<updated>2019-06-05T05:53:45+00:00</updated>
<author>
<name>Brian Sang</name>
<email>sang.bri@gmail.com</email>
</author>
<published>2019-06-01T02:05:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=f126e5bfcc8f41ee5ea29b41ec6eabbc3f441647'/>
<id>f126e5bfcc8f41ee5ea29b41ec6eabbc3f441647</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Reduce client poll timeout when no ifrs</title>
<updated>2019-05-30T04:46:37+00:00</updated>
<author>
<name>Dana Powers</name>
<email>dana.powers@gmail.com</email>
</author>
<published>2019-05-29T06:45:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=9f0b518286ecfc6db8b7abbd2431810c16f1cc80'/>
<id>9f0b518286ecfc6db8b7abbd2431810c16f1cc80</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Update docs for api_version_auto_timeout_ms (#1812)</title>
<updated>2019-05-24T07:15:58+00:00</updated>
<author>
<name>Jeff Widman</name>
<email>jeff@jeffwidman.com</email>
</author>
<published>2019-05-24T06:16:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=cee4d17df7858439e0dbdf3914ca0107e080af7d'/>
<id>cee4d17df7858439e0dbdf3914ca0107e080af7d</id>
<content type='text'>
The docs for `api_version_auto_timeout_ms` mention setting
`api_version='auto'` but that value has been deprecated for years in
favor of `api_version=None`.

Updating the docs for now, and will remove support for `'auto'` in next
major version bump.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The docs for `api_version_auto_timeout_ms` mention setting
`api_version='auto'` but that value has been deprecated for years in
favor of `api_version=None`.

Updating the docs for now, and will remove support for `'auto'` in next
major version bump.
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unused imports (#1808)</title>
<updated>2019-05-23T04:56:25+00:00</updated>
<author>
<name>Jeff Widman</name>
<email>jeff@jeffwidman.com</email>
</author>
<published>2019-05-23T04:56:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=edfafc036f0d9a3b1e5c73f9642ef71c297c1b64'/>
<id>edfafc036f0d9a3b1e5c73f9642ef71c297c1b64</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Do not call state_change_callback with lock (#1775)</title>
<updated>2019-04-03T04:27:49+00:00</updated>
<author>
<name>Dana Powers</name>
<email>dana.powers@gmail.com</email>
</author>
<published>2019-04-03T04:27:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=91d31494d02ea636a991abb4dfb25dd904eefd45'/>
<id>91d31494d02ea636a991abb4dfb25dd904eefd45</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Dont treat popped conn.close() as failure in state change callback (#1773)</title>
<updated>2019-04-02T02:38:48+00:00</updated>
<author>
<name>Dana Powers</name>
<email>dana.powers@gmail.com</email>
</author>
<published>2019-04-02T02:38:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=51313d792a24059d003f5647ec531cfd9d62d7ab'/>
<id>51313d792a24059d003f5647ec531cfd9d62d7ab</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Dont wakeup during maybe_refresh_metadata -- it is only called by poll() (#1769)</title>
<updated>2019-03-31T02:29:30+00:00</updated>
<author>
<name>Dana Powers</name>
<email>dana.powers@gmail.com</email>
</author>
<published>2019-03-31T02:29:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=b1effa24aca3a6bcf2268354caae12ee82d6b36d'/>
<id>b1effa24aca3a6bcf2268354caae12ee82d6b36d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
