<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/python-packages/kafka-python.git/test, branch conn_send_buffer</title>
<subtitle>github.com: mumrah/kafka-python.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/'/>
<entry>
<title>Always mock selector in KafkaClient tests</title>
<updated>2019-09-29T17:48:50+00:00</updated>
<author>
<name>Dana Powers</name>
<email>dana.powers@gmail.com</email>
</author>
<published>2019-09-29T15:05:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=caa40c8f8136cc00f6bd4be1407ae5f3c345a56a'/>
<id>caa40c8f8136cc00f6bd4be1407ae5f3c345a56a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Rely on socket selector to detect completed connection attempts (#1909)</title>
<updated>2019-09-29T02:30:09+00:00</updated>
<author>
<name>Dana Powers</name>
<email>dana.powers@gmail.com</email>
</author>
<published>2019-09-29T02:30:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=89bf6a6ee51e8a54f909eae4785d04e485b91198'/>
<id>89bf6a6ee51e8a54f909eae4785d04e485b91198</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Skip admin integration tests -- travis fixture issues</title>
<updated>2019-09-29T01:18:06+00:00</updated>
<author>
<name>Dana Powers</name>
<email>dana.powers@gmail.com</email>
</author>
<published>2019-09-29T01:18:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=a9f513cf9978b8b9f26ad04bba1d33a9ae6d1b99'/>
<id>a9f513cf9978b8b9f26ad04bba1d33a9ae6d1b99</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix Admin Client api version checking; only test ACL integration on 0.11+</title>
<updated>2019-09-29T00:06:57+00:00</updated>
<author>
<name>Dana Powers</name>
<email>dana.powers@gmail.com</email>
</author>
<published>2019-09-29T00:06:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=98ebff87a78bafbb15dd95c5174c5a1041a848ed'/>
<id>98ebff87a78bafbb15dd95c5174c5a1041a848ed</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixup test_admin_integration test fixtures</title>
<updated>2019-09-28T23:32:15+00:00</updated>
<author>
<name>Dana Powers</name>
<email>dana.powers@gmail.com</email>
</author>
<published>2019-09-28T23:32:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=5381591bac7f1322e7a54e4be65d1a54e2898732'/>
<id>5381591bac7f1322e7a54e4be65d1a54e2898732</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add ACL api to KafkaAdminClient (#1833)</title>
<updated>2019-09-28T21:57:05+00:00</updated>
<author>
<name>Ulrik Johansson</name>
<email>ulrik.johansson@gmail.com</email>
</author>
<published>2019-09-28T21:57:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=76ad6629350f20acfd6038c1e444a89bcd255f89'/>
<id>76ad6629350f20acfd6038c1e444a89bcd255f89</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Convert remaining `KafkaConsumer` tests to `pytest` (#1886)</title>
<updated>2019-08-23T04:14:37+00:00</updated>
<author>
<name>Jeff Widman</name>
<email>jeff@jeffwidman.com</email>
</author>
<published>2019-08-23T04:14:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=61fa0b27685c2d4e67d1b6575ca6797f36eb1bfa'/>
<id>61fa0b27685c2d4e67d1b6575ca6797f36eb1bfa</id>
<content type='text'>
This makes it so the only remaining use of `unittest` is in the old
tests of the deprecated `Simple*` clients. All `KafkaConsumer` tests are
migrated to `pytest`.

I also had to bump the test iterations up on one of the tests, I think there was a race condition there that was more commonly hit under pytest , planning to cleanup that in a followup PR. See https://github.com/dpkp/kafka-python/pull/1886#discussion_r316860737 for details.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This makes it so the only remaining use of `unittest` is in the old
tests of the deprecated `Simple*` clients. All `KafkaConsumer` tests are
migrated to `pytest`.

I also had to bump the test iterations up on one of the tests, I think there was a race condition there that was more commonly hit under pytest , planning to cleanup that in a followup PR. See https://github.com/dpkp/kafka-python/pull/1886#discussion_r316860737 for details.
</pre>
</div>
</content>
</entry>
<entry>
<title>Cleanup handling of KAFKA_VERSION env var in tests (#1887)</title>
<updated>2019-08-22T08:58:28+00:00</updated>
<author>
<name>Jeff Widman</name>
<email>jeff@jeffwidman.com</email>
</author>
<published>2019-08-22T08:58:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=98c005852e36fde0ef44a7b9c60a54f4686651af'/>
<id>98c005852e36fde0ef44a7b9c60a54f4686651af</id>
<content type='text'>
Now that we are using `pytest`, there is no need for a custom decorator
because we can use `pytest.mark.skipif()`.

This makes the code significantly simpler. In particular, dropping the
custom `@kafka_versions()` decorator is necessary because it uses
`func.wraps()` which doesn't play nice with `pytest` fixtures:
- https://github.com/pytest-dev/pytest/issues/677
- https://stackoverflow.com/a/19614807/770425

So this is a pre-requisite to migrating some of those tests to using
pytest fixtures.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now that we are using `pytest`, there is no need for a custom decorator
because we can use `pytest.mark.skipif()`.

This makes the code significantly simpler. In particular, dropping the
custom `@kafka_versions()` decorator is necessary because it uses
`func.wraps()` which doesn't play nice with `pytest` fixtures:
- https://github.com/pytest-dev/pytest/issues/677
- https://stackoverflow.com/a/19614807/770425

So this is a pre-requisite to migrating some of those tests to using
pytest fixtures.</pre>
</div>
</content>
</entry>
<entry>
<title>Minor test cleanup (#1885)</title>
<updated>2019-08-22T01:47:22+00:00</updated>
<author>
<name>Jeff Widman</name>
<email>jeff@jeffwidman.com</email>
</author>
<published>2019-08-22T01:47:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=e49caeb3ebdd36eb4d18a517bc402f8e89dfdbee'/>
<id>e49caeb3ebdd36eb4d18a517bc402f8e89dfdbee</id>
<content type='text'>
Remove unused import, whitespace, etc. No functional changes, just
cleaning it up so the diffs of later changes are cleaner.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove unused import, whitespace, etc. No functional changes, just
cleaning it up so the diffs of later changes are cleaner.</pre>
</div>
</content>
</entry>
<entry>
<title>tests: Use socket.SOCK_STREAM in assertions</title>
<updated>2019-08-15T18:36:05+00:00</updated>
<author>
<name>Ivan A. Melnikov</name>
<email>iv@altlinux.org</email>
</author>
<published>2019-08-12T07:42:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=2180d312c36e62c7175c112b38cbde79c3c90377'/>
<id>2180d312c36e62c7175c112b38cbde79c3c90377</id>
<content type='text'>
socket.SOCK_STREAM is platform specific and on some
platforms (most notably on Linux on MIPS) does not
equal 1; so it's better to use the constant where
appropriate.

This change fixes the tests on my MIPS32 LE machine.

Signed-off-by: Ivan A. Melnikov &lt;iv@altlinux.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
socket.SOCK_STREAM is platform specific and on some
platforms (most notably on Linux on MIPS) does not
equal 1; so it's better to use the constant where
appropriate.

This change fixes the tests on my MIPS32 LE machine.

Signed-off-by: Ivan A. Melnikov &lt;iv@altlinux.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
