delta/python-packages/kafka-python.git/kafka, branch fix-send-to-controller github.com: mumrah/kafka-python.git Fix send to controller 2018-11-18T08:34:20+00:00 Jeff Widman jeff@jeffwidman.com 2018-11-17T10:04:28+00:00 4df9f63dec5715757d1236c1280f29c4c2b7b2d3 The controller send error handling was completely broken. It also pinned the metadata version unnecessarily. Additionally, several of the methods were sending to the controller but either that was unnecessary, or just plain wrong. So updated following the pattern of the Java Admin client. 
The controller send error handling was completely broken.
It also pinned the metadata version unnecessarily.

Additionally, several of the methods were sending to the controller
but either that was unnecessary, or just plain wrong. So updated
following the pattern of the Java Admin client.
Remove support for api versions as strings from KafkaAdmin 2018-11-18T08:22:52+00:00 Jeff Widman jeff@jeffwidman.com 2018-11-17T10:56:55+00:00 d67157cb9a032a6f0493cea128bbcd0528f3e640 This is a new class, so let's not support the old version strings and saddle ourselves with tech debt right from the get-go. 
This is a new class, so let's not support the old version strings and
saddle ourselves with tech debt right from the get-go.
Be explicit with tuples for %s formatting 2018-11-18T08:21:18+00:00 Jeff Widman jeff@jeffwidman.com 2018-11-13T19:57:45+00:00 1d443638e22c2d360086b8d7cee8b5d930741d12 Fix #1633 
Fix #1633
Stop using broker-errors for client-side problems 2018-11-18T08:20:55+00:00 Jeff Widman jeff@jeffwidman.com 2018-11-17T09:37:15+00:00 f3105a434f3bd2fb3f8899e4861e187e786b03da `UnsupportedVersionError` is intended to indicate a server-side error: https://github.com/dpkp/kafka-python/blob/ba7372e44ffa1ee49fb4d5efbd67534393e944db/kafka/errors.py#L375-L378 So we should not be raising it for client-side errors. I realize that semantically this seems like the appropriate error to raise. However, this is confusing when debugging... for a real-life example, see https://github.com/Parsely/pykafka/issues/697. So I strongly feel that server-side errors should be kept separate from client-side errors, even if all the client is doing is proactively protecting against hitting a situation where the broker would return this error. 
`UnsupportedVersionError` is intended to indicate a server-side error:
https://github.com/dpkp/kafka-python/blob/ba7372e44ffa1ee49fb4d5efbd67534393e944db/kafka/errors.py#L375-L378

So we should not be raising it for client-side errors. I realize that
semantically this seems like the appropriate error to raise. However,
this is confusing when debugging... for a real-life example, see
https://github.com/Parsely/pykafka/issues/697. So I strongly feel that
server-side errors should be kept separate from client-side errors,
even if all the client is doing is proactively protecting against
hitting a situation where the broker would return this error.
Use TypeError for invalid type 2018-11-17T08:41:24+00:00 Jeff Widman jeff@jeffwidman.com 2018-11-13T21:58:51+00:00 21d68c98470eab6b9e7e5c934017af4a4fd24748 






raising logging level on messages signalling data loss (#1553)
2018-11-10T20:46:54+00:00

Alexander Sibiryakov
sibiryakov@users.noreply.github.com

2018-11-10T20:46:54+00:00

cd47701ba63fc77309066e27b73f50d0150e3e1b












set socket timeout for the wake_w (#1577)
2018-11-10T20:45:51+00:00

flaneur
me.ssword@gmail.com

2018-11-10T20:45:51+00:00

1c0e8942dc75837a2e43b93e0ed6700fb7752a03












(Attempt to) Fix deadlock between consumer and heartbeat (#1628)
2018-11-10T20:45:01+00:00

Dana Powers
dana.powers@gmail.com

2018-11-10T20:45:01+00:00

0a2ccba3cb1b8636f615a30821123720773a8dfa












Fix typo
2018-11-08T03:20:50+00:00

Jeff Widman
jeff@jeffwidman.com

2018-11-08T03:20:50+00:00

9d44e3cf8b6a75b11f1087282157aa48eba68a64












Pre-compile pack/unpack function calls
2018-10-29T19:57:42+00:00

billyevans
pervushinai@gmail.com

2018-07-20T21:11:41+00:00

3689da3d5c02e362d872cf1fb2d65201419c4b93

I noticed that pack/unpack functions from
https://github.com/dpkp/kafka-python/blob/master/kafka/protocol/types.py
might be slightly improved. I made pre-compilation for them. It gives
about 10% better performance compared to the current implementation.

Consumption of 100msg:
```
239884    0.187    0.000    0.287    0.000 types.py:18(_unpack) # new version
239884    0.192    0.000    0.323    0.000 types.py:17(_unpack)
```

I also made some profiling for producers/consumers. It gives about
1-1.5% time savings.





I noticed that pack/unpack functions from
https://github.com/dpkp/kafka-python/blob/master/kafka/protocol/types.py
might be slightly improved. I made pre-compilation for them. It gives
about 10% better performance compared to the current implementation.

Consumption of 100msg:
```
239884    0.187    0.000    0.287    0.000 types.py:18(_unpack) # new version
239884    0.192    0.000    0.323    0.000 types.py:17(_unpack)
```

I also made some profiling for producers/consumers. It gives about
1-1.5% time savings.