<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/python-packages/kafka-python.git, branch simplify-version-checking-using-pytest-skipif</title>
<subtitle>github.com: mumrah/kafka-python.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/'/>
<entry>
<title>Cleanup handling of KAFKA_VERSION env var in tests</title>
<updated>2019-08-22T08:25:45+00:00</updated>
<author>
<name>Jeff Widman</name>
<email>jeff@jeffwidman.com</email>
</author>
<published>2019-08-22T08:15:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=bc87474632637dee3e09a878f91ee6ff38e3a8bd'/>
<id>bc87474632637dee3e09a878f91ee6ff38e3a8bd</id>
<content type='text'>
Now that we are using `pytest`, there is no need for a custom decorator
because we can use `pytest.mark.skipif()`.

This makes the code significantly simpler. In particular, dropping the
custom `@kafka_versions()` decorator is necessary because it uses
`func.wraps()` which doesn't play nice with `pytest` fixtures:
- https://github.com/pytest-dev/pytest/issues/677
- https://stackoverflow.com/a/19614807/770425

So this is a pre-requisite to migrating some of those tests to using
pytest fixtures.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now that we are using `pytest`, there is no need for a custom decorator
because we can use `pytest.mark.skipif()`.

This makes the code significantly simpler. In particular, dropping the
custom `@kafka_versions()` decorator is necessary because it uses
`func.wraps()` which doesn't play nice with `pytest` fixtures:
- https://github.com/pytest-dev/pytest/issues/677
- https://stackoverflow.com/a/19614807/770425

So this is a pre-requisite to migrating some of those tests to using
pytest fixtures.
</pre>
</div>
</content>
</entry>
<entry>
<title>Minor test cleanup (#1885)</title>
<updated>2019-08-22T01:47:22+00:00</updated>
<author>
<name>Jeff Widman</name>
<email>jeff@jeffwidman.com</email>
</author>
<published>2019-08-22T01:47:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=e49caeb3ebdd36eb4d18a517bc402f8e89dfdbee'/>
<id>e49caeb3ebdd36eb4d18a517bc402f8e89dfdbee</id>
<content type='text'>
Remove unused import, whitespace, etc. No functional changes, just
cleaning it up so the diffs of later changes are cleaner.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove unused import, whitespace, etc. No functional changes, just
cleaning it up so the diffs of later changes are cleaner.</pre>
</div>
</content>
</entry>
<entry>
<title>Reduce internal client poll timeout for consumer iterator interface (#1824)</title>
<updated>2019-08-16T18:04:10+00:00</updated>
<author>
<name>Dana Powers</name>
<email>dana.powers@gmail.com</email>
</author>
<published>2019-08-16T18:04:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=5bc25292b8bb5b20ba2fff481fdc77b9909d0831'/>
<id>5bc25292b8bb5b20ba2fff481fdc77b9909d0831</id>
<content type='text'>
More attempts to address heartbeat timing issues in consumers, especially with the iterator interface. Here we can reduce the `client.poll` timeout to at most the retry backoff (typically 100ms) so that the consumer iterator interface doesn't block for longer than the heartbeat timeout.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
More attempts to address heartbeat timing issues in consumers, especially with the iterator interface. Here we can reduce the `client.poll` timeout to at most the retry backoff (typically 100ms) so that the consumer iterator interface doesn't block for longer than the heartbeat timeout.</pre>
</div>
</content>
</entry>
<entry>
<title>Update conn.py</title>
<updated>2019-08-16T18:00:15+00:00</updated>
<author>
<name>Cameron Boulton</name>
<email>cameronboulton@gmail.com</email>
</author>
<published>2019-08-15T23:59:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=ace6af5e5d2ff7b900bc694065562127b4efe8dc'/>
<id>ace6af5e5d2ff7b900bc694065562127b4efe8dc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: Use socket.SOCK_STREAM in assertions</title>
<updated>2019-08-15T18:36:05+00:00</updated>
<author>
<name>Ivan A. Melnikov</name>
<email>iv@altlinux.org</email>
</author>
<published>2019-08-12T07:42:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=2180d312c36e62c7175c112b38cbde79c3c90377'/>
<id>2180d312c36e62c7175c112b38cbde79c3c90377</id>
<content type='text'>
socket.SOCK_STREAM is platform specific and on some
platforms (most notably on Linux on MIPS) does not
equal 1; so it's better to use the constant where
appropriate.

This change fixes the tests on my MIPS32 LE machine.

Signed-off-by: Ivan A. Melnikov &lt;iv@altlinux.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
socket.SOCK_STREAM is platform specific and on some
platforms (most notably on Linux on MIPS) does not
equal 1; so it's better to use the constant where
appropriate.

This change fixes the tests on my MIPS32 LE machine.

Signed-off-by: Ivan A. Melnikov &lt;iv@altlinux.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Break FindCoordinator into request/response methods</title>
<updated>2019-07-31T18:26:43+00:00</updated>
<author>
<name>Jeff Widman</name>
<email>jeff@jeffwidman.com</email>
</author>
<published>2019-07-31T01:35:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=ea35fdfe1d66eb481e3406ad161a1255573dd50f'/>
<id>ea35fdfe1d66eb481e3406ad161a1255573dd50f</id>
<content type='text'>
This splits the `_find_coordinator_id()` method (which is blocking) into
request generation / response parsing methods.

The public API does not change. However, this allows power users who are
willing to deal with risk of private methods changing under their feet
to decouple generating the message futures from processing their
responses. In other words, you can use these to fire a bunch of requests
at once and delay processing the responses until all requests are fired.

This is modeled on the work done in #1845.

Additionally, I removed the code that tried to leverage the error
checking from `cluster.add_group_coordinator()`. That code had changed
in #1822, removing most of the error checking... so it no longer adds
any value, but instead merely increases complexity and coupling.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This splits the `_find_coordinator_id()` method (which is blocking) into
request generation / response parsing methods.

The public API does not change. However, this allows power users who are
willing to deal with risk of private methods changing under their feet
to decouple generating the message futures from processing their
responses. In other words, you can use these to fire a bunch of requests
at once and delay processing the responses until all requests are fired.

This is modeled on the work done in #1845.

Additionally, I removed the code that tried to leverage the error
checking from `cluster.add_group_coordinator()`. That code had changed
in #1822, removing most of the error checking... so it no longer adds
any value, but instead merely increases complexity and coupling.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix minor typo (#1865)</title>
<updated>2019-07-14T15:22:10+00:00</updated>
<author>
<name>Carson Ip</name>
<email>carsonip@users.noreply.github.com</email>
</author>
<published>2019-07-14T15:22:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=eed25fc36110b12ec370b4d0e332173abce9076f'/>
<id>eed25fc36110b12ec370b4d0e332173abce9076f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Update link to upstream Kafka docs</title>
<updated>2019-07-11T18:49:56+00:00</updated>
<author>
<name>Jeff Widman</name>
<email>jeff@jeffwidman.com</email>
</author>
<published>2019-07-11T18:49:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=fb87a353d99b3271105d0941f39ee64bf2ab6858'/>
<id>fb87a353d99b3271105d0941f39ee64bf2ab6858</id>
<content type='text'>
the new consumer is now the standard consumer, so they dropped the `new_` from the anchor</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
the new consumer is now the standard consumer, so they dropped the `new_` from the anchor</pre>
</div>
</content>
</entry>
<entry>
<title>Add the `sasl_kerberos_domain_name` arg to `KafkaAdminClient`</title>
<updated>2019-06-28T19:41:46+00:00</updated>
<author>
<name>Jeff Widman</name>
<email>jeff@jeffwidman.com</email>
</author>
<published>2019-06-28T19:34:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=279a7dd85d5d15f8fffde95e0a2425cb8a2d4fe3'/>
<id>279a7dd85d5d15f8fffde95e0a2425cb8a2d4fe3</id>
<content type='text'>
Previously the `sasl_kerberos_domain_name` was missing from the Admin
client. It is already present in the Consumer/Producer, and in all three
cases gets transparently passed down to the client.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously the `sasl_kerberos_domain_name` was missing from the Admin
client. It is already present in the Consumer/Producer, and in all three
cases gets transparently passed down to the client.
</pre>
</div>
</content>
</entry>
<entry>
<title>Update KafkaAdminClient Docs</title>
<updated>2019-06-21T18:59:24+00:00</updated>
<author>
<name>Rob Cardy</name>
<email>rob.cardy@shopify.com</email>
</author>
<published>2019-06-21T18:15:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/kafka-python.git/commit/?id=5a72a62078b681fdfae780957bd65c66f5c2ff6d'/>
<id>5a72a62078b681fdfae780957bd65c66f5c2ff6d</id>
<content type='text'>
Updated to include SASL_PLAINTEXT and SASL_SSL as options for security_protocol.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Updated to include SASL_PLAINTEXT and SASL_SSL as options for security_protocol.</pre>
</div>
</content>
</entry>
</feed>
