From 449ce35a34356d6091870688989b70efdb5f9053 Mon Sep 17 00:00:00 2001 From: Daniel Kraft Date: Wed, 27 Jun 2018 17:47:07 +0200 Subject: Pass down API version in SimpleJSONRPCServer. JSON-RPC version 1.0 requires the 'error' key to be set in the response even if there is no error. This is correctly implemented Payload.response -- but for that to work, the API version has to be passed down in SimpleJSONRPCServer when it calls dumps to construct the response. This was missing, so that JSON-RPC 1.0 requests were answered with a 2.0 response. --- jsonrpclib/SimpleJSONRPCServer.py | 1 + 1 file changed, 1 insertion(+) (limited to 'jsonrpclib/SimpleJSONRPCServer.py') diff --git a/jsonrpclib/SimpleJSONRPCServer.py b/jsonrpclib/SimpleJSONRPCServer.py index 3a0a3bb..a22ae7c 100644 --- a/jsonrpclib/SimpleJSONRPCServer.py +++ b/jsonrpclib/SimpleJSONRPCServer.py @@ -106,6 +106,7 @@ class SimpleJSONRPCDispatcher(SimpleXMLRPCServer.SimpleXMLRPCDispatcher): return None try: response = jsonrpclib.dumps(response, + version=get_version(request), methodresponse=True, rpcid=request['id'] ) -- cgit v1.2.1