From 64ba8e99ec1cc82f99fb9ad8ab1da10b25fe6eb1 Mon Sep 17 00:00:00 2001 From: Timothy Crosley Date: Thu, 16 Apr 2020 22:51:08 -0700 Subject: Initial show_diff coverage --- isort/api.py | 2 +- tests/test_api.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/isort/api.py b/isort/api.py index 4648d77a..8e3e2018 100644 --- a/isort/api.py +++ b/isort/api.py @@ -486,7 +486,6 @@ def sort_file( disregard_skip=disregard_skip, **config_kwargs, ) - source_file.stream.close() if changed: if show_diff or ask_to_apply: source_file.stream.seek(0) @@ -499,6 +498,7 @@ def sort_file( str(source_file.path) ): return + source_file.stream.close() tmp_file.replace(source_file.path) if not config.quiet: print(f"Fixing {source_file.path}") diff --git a/tests/test_api.py b/tests/test_api.py index 44db6e62..bc0a4ffa 100644 --- a/tests/test_api.py +++ b/tests/test_api.py @@ -15,6 +15,7 @@ def test_sort_file(tmpdir) -> None: imperfect = tmpdir.join(f"test_needs_changes.py") imperfect.write_text("import b\nimport a\n", "utf8") api.sort_file(imperfect, write_to_stdout=True, show_diff=True) + api.sort_file(imperfect, show_diff=True) def test_check_file(tmpdir) -> None: -- cgit v1.2.1