<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/python-packages/isort.git, branch separate-integration-test</title>
<subtitle>github.com: timothycrosley/isort.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/isort.git/'/>
<entry>
<title>Start work to separate integration and unit tests</title>
<updated>2020-08-23T07:09:37+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2020-08-23T07:09:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/isort.git/commit/?id=180bdf9abc91223eb9d7b9e713ead7451095c5da'/>
<id>180bdf9abc91223eb9d7b9e713ead7451095c5da</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed #1396: comments in imports with ; can keep isort from recognizing import line.</title>
<updated>2020-08-23T01:19:16+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2020-08-23T01:19:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/isort.git/commit/?id=19221a3e3c4e17e51056d1e70cd565b16f149cea'/>
<id>19221a3e3c4e17e51056d1e70cd565b16f149cea</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add githook config file support to changelog</title>
<updated>2020-08-23T00:24:20+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2020-08-23T00:24:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/isort.git/commit/?id=7bbe002400fc3cb9e2342811a9e0376620b085ce'/>
<id>7bbe002400fc3cb9e2342811a9e0376620b085ce</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add initial integration test</title>
<updated>2020-08-23T00:22:47+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2020-08-23T00:22:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/isort.git/commit/?id=c225da117a146b8ec1496840900126678e47ccc4'/>
<id>c225da117a146b8ec1496840900126678e47ccc4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #1400 from diseraluca/issue/1397</title>
<updated>2020-08-23T00:20:14+00:00</updated>
<author>
<name>Timothy Edmund Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2020-08-23T00:20:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/isort.git/commit/?id=dad623721a71cec9c4e5b7ed8602f493224a1b5e'/>
<id>dad623721a71cec9c4e5b7ed8602f493224a1b5e</id>
<content type='text'>
Extends git_hook to allow for a user-specified configuration file.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Extends git_hook to allow for a user-specified configuration file.</pre>
</div>
</content>
</entry>
<entry>
<title>Corrects a typo in the tests/test_hooks.py.</title>
<updated>2020-08-22T12:17:37+00:00</updated>
<author>
<name>Luca Di Sera</name>
<email>disera.luca@gmail.com</email>
</author>
<published>2020-08-22T12:17:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/isort.git/commit/?id=b6a96b2b79e7e50536750cdef2a7e729d3ae6fc1'/>
<id>b6a96b2b79e7e50536750cdef2a7e729d3ae6fc1</id>
<content type='text'>
In `test_git_hook_uses_the_configuration_file_specified_in_settings_path`,
`modified_file_path` incorrectly pointed to a file that was a sibling of the
configuration file, such that the configuration file would have been found
indepently of the `settings_file` configuration.

`modified_file_path` now points to a file that lives one level higher than the
configuration file.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In `test_git_hook_uses_the_configuration_file_specified_in_settings_path`,
`modified_file_path` incorrectly pointed to a file that was a sibling of the
configuration file, such that the configuration file would have been found
indepently of the `settings_file` configuration.

`modified_file_path` now points to a file that lives one level higher than the
configuration file.
</pre>
</div>
</content>
</entry>
<entry>
<title>Extends git_hook to allow for a user-specified configuration file.</title>
<updated>2020-08-22T11:04:56+00:00</updated>
<author>
<name>Luca Di Sera</name>
<email>disera.luca@gmail.com</email>
</author>
<published>2020-08-22T11:04:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/isort.git/commit/?id=3c62f89437af6d696173e6a05d5ec828bbf6ebc0'/>
<id>3c62f89437af6d696173e6a05d5ec828bbf6ebc0</id>
<content type='text'>
The behavior of the `git_hook` function was to search for a configuration file
by starting from the directory containing the first staged file and moving
upwards until a configuration file was found or a certain number of directories
were checked.

If the project configuration file is not stored in a directory that is a parent
to each python file in the codebase, the `git_hook` function was unable to
retrieve the file.

For example, this might happen with a configuration such as the following:

    ```
    git-root/
      config/
        .isort.cfg
      src/
        ...
    ```

To allow for the `git_hook` function to support those project structures without
breaking backwards compatibility, an optional argument, `settings_file`, was
added to it.

When `settings_file` is the empty string the function behaves as before.
Otherwise, `settings_file` is considered a path to a valid configuration file
that will be used for the hook's run.

A test in `tests/test_hooks.py` was added to cover for this case.

`README.md#Git hook` was modified to mention the new interface.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The behavior of the `git_hook` function was to search for a configuration file
by starting from the directory containing the first staged file and moving
upwards until a configuration file was found or a certain number of directories
were checked.

If the project configuration file is not stored in a directory that is a parent
to each python file in the codebase, the `git_hook` function was unable to
retrieve the file.

For example, this might happen with a configuration such as the following:

    ```
    git-root/
      config/
        .isort.cfg
      src/
        ...
    ```

To allow for the `git_hook` function to support those project structures without
breaking backwards compatibility, an optional argument, `settings_file`, was
added to it.

When `settings_file` is the empty string the function behaves as before.
Otherwise, `settings_file` is considered a path to a valid configuration file
that will be used for the hook's run.

A test in `tests/test_hooks.py` was added to cover for this case.

`README.md#Git hook` was modified to mention the new interface.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'develop' of https://github.com/timothycrosley/isort into develop</title>
<updated>2020-08-22T08:14:44+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2020-08-22T08:14:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/isort.git/commit/?id=a35d565763cd6224717f14a7faeb162475602f62'/>
<id>a35d565763cd6224717f14a7faeb162475602f62</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Update changelog to mention #1389 fix</title>
<updated>2020-08-22T08:14:38+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2020-08-22T08:14:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/isort.git/commit/?id=ce52dca988b528525e9cde550a3c2be22f2db90e'/>
<id>ce52dca988b528525e9cde550a3c2be22f2db90e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #1390 from sztamas/issue/1389/ensure_new_line_before_comments-bug</title>
<updated>2020-08-22T08:12:58+00:00</updated>
<author>
<name>Timothy Edmund Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2020-08-22T08:12:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/isort.git/commit/?id=f960ee88fe25a3f89ebcf990234138c1bff9b082'/>
<id>f960ee88fe25a3f89ebcf990234138c1bff9b082</id>
<content type='text'>
Issue/1389/ensure new line before comments bug</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Issue/1389/ensure new line before comments bug</pre>
</div>
</content>
</entry>
</feed>
