From 36440f79bddc2c1aa4a7a3dd8c2557dca3926639 Mon Sep 17 00:00:00 2001 From: Jingyang Liang Date: Thu, 22 Apr 2021 15:26:18 +0800 Subject: Fix missing stderr when the progress parameter of _clone is None --- git/repo/base.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'git') diff --git a/git/repo/base.py b/git/repo/base.py index a28c9d28..b1d0cdbc 100644 --- a/git/repo/base.py +++ b/git/repo/base.py @@ -988,8 +988,6 @@ class Repo(object): def _clone(cls, git: 'Git', url: PathLike, path: PathLike, odb_default_type: Type[GitCmdObjectDB], progress: Optional[Callable], multi_options: Optional[List[str]] = None, **kwargs: Any ) -> 'Repo': - progress_checked = to_progress_instance(progress) - odbt = kwargs.pop('odbt', odb_default_type) # when pathlib.Path or other classbased path is passed @@ -1012,9 +1010,9 @@ class Repo(object): if multi_options: multi = ' '.join(multi_options).split(' ') proc = git.clone(multi, Git.polish_url(url), clone_path, with_extended_output=True, as_process=True, - v=True, universal_newlines=True, **add_progress(kwargs, git, progress_checked)) - if progress_checked: - handle_process_output(proc, None, progress_checked.new_message_handler(), + v=True, universal_newlines=True, **add_progress(kwargs, git, progress)) + if progress: + handle_process_output(proc, None, to_progress_instance(progress).new_message_handler(), finalize_process, decode_streams=False) else: (stdout, stderr) = proc.communicate() -- cgit v1.2.1