From 3910abfc2ab12a5d5a210b71c43b7a2318311323 Mon Sep 17 00:00:00 2001 From: Kostis Anagnostopoulos Date: Sat, 22 Oct 2016 03:40:01 +0200 Subject: submodule-TCs: stop monekypatching smmap.MapRegion with files in Windows Obviously it is not needed anymore, or nothing is worse without this monkeypatch. --- git/test/test_submodule.py | 14 -------------- 1 file changed, 14 deletions(-) (limited to 'git/test/test_submodule.py') diff --git a/git/test/test_submodule.py b/git/test/test_submodule.py index fcaad04b..e9fd8153 100644 --- a/git/test/test_submodule.py +++ b/git/test/test_submodule.py @@ -38,20 +38,6 @@ from git.util import ( import os.path as osp -# Change the configuration if possible to prevent the underlying memory manager -# to keep file handles open. On windows we get problems as they are not properly -# closed due to mmap bugs on windows (as it appears) -if is_win: - try: - import smmap.util # @UnusedImport - smmap.util.MapRegion._test_read_into_memory = True - except ImportError: - sys.stderr.write("The submodule tests will fail as some files cannot be removed due to open file handles.\n") - sys.stderr.write( - "The latest version of gitdb uses a memory map manager which can be configured to work around this problem") -# END handle windows platform - - class TestRootProgress(RootUpdateProgress): """Just prints messages, for now without checking the correctness of the states""" -- cgit v1.2.1 From 9db2ff10e59b2657220d1804df19fcf946539385 Mon Sep 17 00:00:00 2001 From: Kostis Anagnostopoulos Date: Sat, 22 Oct 2016 14:48:40 +0200 Subject: fix(win_mmap): unmark hidden win_errors due to smmap unicode foes Now 2 more TCs pass in Windows: + TestRepo.test_file_handle_leaks() + TestObjDbPerformance.test_random_access() See https://github.com/gitpython-developers/smmap/pull/30 --- git/test/test_submodule.py | 1 - 1 file changed, 1 deletion(-) (limited to 'git/test/test_submodule.py') diff --git a/git/test/test_submodule.py b/git/test/test_submodule.py index e9fd8153..53f3c352 100644 --- a/git/test/test_submodule.py +++ b/git/test/test_submodule.py @@ -9,7 +9,6 @@ import git from git.cmd import Git from git.compat import ( string_types, - is_win, ) from git.exc import ( InvalidGitRepositoryError, -- cgit v1.2.1