From be44602b633cfb49a472e192f235ba6de0055d38 Mon Sep 17 00:00:00 2001 From: Kostis Anagnostopoulos Date: Mon, 3 Oct 2016 12:25:09 +0200 Subject: hidden win-errs: Let leaking TCs run till end, then hide + Detect code breaking the body of TCs eventually hidden win-errors by raising SkipTest ALAP. + submodule.base.py: import classes from `git.objects` instead of `utils`. + had to ++ ulimit 100->110 for the extra code tested (more leaks :-) + Centralize is_win detection. --- git/test/test_docs.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'git/test/test_docs.py') diff --git a/git/test/test_docs.py b/git/test/test_docs.py index c5be3ce9..6e505dd9 100644 --- a/git/test/test_docs.py +++ b/git/test/test_docs.py @@ -5,10 +5,7 @@ # This module is part of GitPython and is released under # the BSD License: http://www.opensource.org/licenses/bsd-license.php import os -from unittest.case import skipIf -from git.compat import is_win -from git.test.lib.helper import HIDE_WINDOWS_KNOWN_ERRORS from git.test.lib import TestBase from git.test.lib.helper import with_rw_directory @@ -19,9 +16,9 @@ class Tutorials(TestBase): import gc gc.collect() - @skipIf(HIDE_WINDOWS_KNOWN_ERRORS and is_win, - "FIXME: helper.wrapper fails with: PermissionError: [WinError 5] Access is denied: " - "'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\test_work_tree_unsupportedryfa60di\\master_repo\\.git\\objects\\pack\\pack-bc9e0787aef9f69e1591ef38ea0a6f566ec66fe3.idx") # noqa E501 + # @skipIf(HIDE_WINDOWS_KNOWN_ERRORS, + # "FIXME: helper.wrapper fails with: PermissionError: [WinError 5] Access is denied: " + # "'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\test_work_tree_unsupportedryfa60di\\master_repo\\.git\\objects\\pack\\pack-bc9e0787aef9f69e1591ef38ea0a6f566ec66fe3.idx") # noqa E501 @with_rw_directory def test_init_repo_object(self, rw_dir): # [1-test_init_repo_object] -- cgit v1.2.1