From f8775f9b8e40b18352399445dba99dd1d805e8c6 Mon Sep 17 00:00:00 2001 From: Sebastian Thiel Date: Sun, 7 Feb 2016 12:20:04 +0100 Subject: fix(cmd): prevent deadlock on clone/fetch/pull We keep stdout closed, which seems to have the side-effect of stdout being connected to your TTY, in case you run a terminal. However, this shold also prevent deadlocks, as only stderr is used. The alternative would have been to try to fetch lines concurrently, and we have been there. For clone(), `communicate()` is used, and with some luck this will just do the right thing. Even though last time I checked, it didn't ... ? Lets see. Stab at #72 --- git/config.py | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'git/config.py') diff --git a/git/config.py b/git/config.py index ea5e17be..51b15989 100644 --- a/git/config.py +++ b/git/config.py @@ -160,14 +160,7 @@ class GitConfigParser(with_metaclass(MetaParserBuilder, cp.RawConfigParser, obje OPTVALUEONLY = re.compile(optvalueonly_source) - OPTCRE = re.compile( - optvalueonly_source # very permissive, incuding leading whitespace - + r'\s*(?P[:=])\s*' # any number of space/tab, - # followed by separator - # (either : or =), followed - # by any # space/tab - + r'(?P.*)$' # everything up to eol - ) + OPTCRE = re.compile(optvalueonly_source + r'\s*(?P[:=])\s*' + r'(?P.*)$') del optvalueonly_source -- cgit v1.2.1