<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/python-packages/flake8.git/tests/unit/test_style_guide.py, branch pre_commit_config</title>
<subtitle>gitlab.com: pycqa/flake8.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/'/>
<entry>
<title>Add tests for the expected behaviour of per-file-ignores</title>
<updated>2018-10-27T13:01:14+00:00</updated>
<author>
<name>Ian Stapleton Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2018-10-26T20:01:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=1433a008b30cb97af2c28709daf763ae872c5bf9'/>
<id>1433a008b30cb97af2c28709daf763ae872c5bf9</id>
<content type='text'>
These show that there were some subtle bugs in how we were matching
things and that there are bugs that need to be fixed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These show that there were some subtle bugs in how we were matching
things and that there are bugs that need to be fixed.
</pre>
</div>
</content>
</entry>
<entry>
<title>Implement --extend-ignore</title>
<updated>2018-05-16T06:50:26+00:00</updated>
<author>
<name>Ville Skyttä</name>
<email>ville.skytta@iki.fi</email>
</author>
<published>2018-05-13T20:54:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=e520c2d936133c68369782e48cdb9f39d4f67dc1'/>
<id>e520c2d936133c68369782e48cdb9f39d4f67dc1</id>
<content type='text'>
Refs #365
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Refs #365
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename style_guide.Error to style_guide.Violation</title>
<updated>2017-06-04T12:57:28+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2017-06-04T12:57:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=92c367dee4e5908745822902adfda0bd915b1380'/>
<id>92c367dee4e5908745822902adfda0bd915b1380</id>
<content type='text'>
Move all Violation related methods from the StyleGuide to our Violation
class.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move all Violation related methods from the StyleGuide to our Violation
class.
</pre>
</div>
</content>
</entry>
<entry>
<title>Move unit tests for StyleGuide decision logic</title>
<updated>2017-06-03T00:16:28+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2017-06-03T00:16:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=583fda7a70eb49dcf3b7b83dba0dd646d224592f'/>
<id>583fda7a70eb49dcf3b7b83dba0dd646d224592f</id>
<content type='text'>
Convert it to test the DecisionEngine class directly and put them in
their own file.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Convert it to test the DecisionEngine class directly and put them in
their own file.
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor decision logic into its own object</title>
<updated>2017-06-02T01:36:37+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2017-06-02T01:36:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=7fef0af0f5521a8cec8451cb8dd01952acd78408'/>
<id>7fef0af0f5521a8cec8451cb8dd01952acd78408</id>
<content type='text'>
In dealing with the decision logic in the StyleGuide recently I
recognized that the logic really doesn't belong strictly on the
StyleGuide. A separate object makes perfect sense especially from the
perspective of testability. This is a minor refactor intended solely to
facilitate further testing and perhaps making the logic easier to
understand for others.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In dealing with the decision logic in the StyleGuide recently I
recognized that the logic really doesn't belong strictly on the
StyleGuide. A separate object makes perfect sense especially from the
perspective of testability. This is a minor refactor intended solely to
facilitate further testing and perhaps making the logic easier to
understand for others.
</pre>
</div>
</content>
</entry>
<entry>
<title>Simplify conditoinal in decision logic</title>
<updated>2017-05-28T01:34:04+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2017-05-28T01:34:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=aefa79535f985bd19c375332abea6f3712815a0a'/>
<id>aefa79535f985bd19c375332abea6f3712815a0a</id>
<content type='text'>
Add test to cover branch of decision logic we were not previously
exercising
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add test to cover branch of decision logic we were not previously
exercising
</pre>
</div>
</content>
</entry>
<entry>
<title>Add extra test cases for violation decisions</title>
<updated>2017-05-28T01:16:15+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2017-05-28T01:16:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=178092954d2b6d5293f6211bd4e2f9f37bb8c525'/>
<id>178092954d2b6d5293f6211bd4e2f9f37bb8c525</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Further refine our logic handling selection</title>
<updated>2017-05-28T00:22:38+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2017-05-28T00:22:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=2baaf00e83073a749238798983de4b8161e3e328'/>
<id>2baaf00e83073a749238798983de4b8161e3e328</id>
<content type='text'>
There was a *very* subtle bug in how we handle blanket select statements
with error codes that are in our DEFAULT_IGNORE. In the specific case,
users were specifying ``--select E`` and E126 was not being properly
reported. This unveiled further logic bugs as we refined this.

Closes #318
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There was a *very* subtle bug in how we handle blanket select statements
with error codes that are in our DEFAULT_IGNORE. In the specific case,
users were specifying ``--select E`` and E126 was not being properly
reported. This unveiled further logic bugs as we refined this.

Closes #318
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix subtle reporting bug for default on plugins</title>
<updated>2016-11-16T01:56:18+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2016-11-16T01:37:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=c50b747a1a8b470574b5fc1016ee8cb598ab951e'/>
<id>c50b747a1a8b470574b5fc1016ee8cb598ab951e</id>
<content type='text'>
When we refactored our decision process to fix #239, we broke a subtle
corner case where extensions that are not off-by-default are to be
reported.

This further refactors that logic and adds specific tests around it to
ensure it works as expected and doesn't regress.

Closes #257
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When we refactored our decision process to fix #239, we broke a subtle
corner case where extensions that are not off-by-default are to be
reported.

This further refactors that logic and adds specific tests around it to
ensure it works as expected and doesn't regress.

Closes #257
</pre>
</div>
</content>
</entry>
<entry>
<title>Handle a previously unhandled code scenario</title>
<updated>2016-11-09T02:00:01+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2016-11-02T15:20:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=4f04ca549b325e3b88756040e5baadb535b35e3f'/>
<id>4f04ca549b325e3b88756040e5baadb535b35e3f</id>
<content type='text'>
Previously, we didn't handle the case where an error code was implicitly
ignored (by not being in --select) and implicitly selected (by not being
in --ignore). This means we need to update StyleGuide#_decision_for and
StyleGuide#is_user_selected to handle these cases.

Closes #242
Related-to #239
Related-to !132
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, we didn't handle the case where an error code was implicitly
ignored (by not being in --select) and implicitly selected (by not being
in --ignore). This means we need to update StyleGuide#_decision_for and
StyleGuide#is_user_selected to handle these cases.

Closes #242
Related-to #239
Related-to !132
</pre>
</div>
</content>
</entry>
</feed>
