<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/python-packages/flake8.git/src/flake8, branch bug/193</title>
<subtitle>gitlab.com: pycqa/flake8.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/'/>
<entry>
<title>Open our output file in append mode always</title>
<updated>2016-07-29T22:18:47+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2016-07-29T22:18:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=f88fce950941e86f42927bd768cf31dc2e516cdd'/>
<id>f88fce950941e86f42927bd768cf31dc2e516cdd</id>
<content type='text'>
This avoid overwriting portions of our log output when using Flake8
in verbose mode.

Closes #193
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This avoid overwriting portions of our log output when using Flake8
in verbose mode.

Closes #193
</pre>
</div>
</content>
</entry>
<entry>
<title>Diable multiprocessing behaviour on Windows</title>
<updated>2016-07-29T12:04:37+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2016-07-29T11:49:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=429d8a196e1ad7317b195b07f0f6a06027d4476f'/>
<id>429d8a196e1ad7317b195b07f0f6a06027d4476f</id>
<content type='text'>
Due to https://bugs.python.org/issue27649, we cannot continue to
expect multiprocessing to work as we expect and document it on Windows.
As such, we are going to revert back to our previous behaviour of
disabling it across all versions of Python on Windows to provide the
default expected behaviour of Flake8 on that Operating System.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Due to https://bugs.python.org/issue27649, we cannot continue to
expect multiprocessing to work as we expect and document it on Windows.
As such, we are going to revert back to our previous behaviour of
disabling it across all versions of Python on Windows to provide the
default expected behaviour of Flake8 on that Operating System.
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow plugins that are on by default to be ignored</title>
<updated>2016-07-29T00:28:13+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2016-07-29T00:24:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=c670217c24db25ad3cab699f6394372a94777379'/>
<id>c670217c24db25ad3cab699f6394372a94777379</id>
<content type='text'>
Previously, to ensure that plugins on by default were reported, we
added them to the select list. This means that ignoring them became
impossible. To accomodate our reporting logic and a user's ability
to ignore, we need to keep our select and extended select lists
separated.

This allows us to have a better understanding of who is selecting what,
where, and how and make our decision as to whether or not an error
should be reported more wisely.

Closes #195
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, to ensure that plugins on by default were reported, we
added them to the select list. This means that ignoring them became
impossible. To accomodate our reporting logic and a user's ability
to ignore, we need to keep our select and extended select lists
separated.

This allows us to have a better understanding of who is selecting what,
where, and how and make our decision as to whether or not an error
should be reported more wisely.

Closes #195
</pre>
</div>
</content>
</entry>
<entry>
<title>Raise exception when entry_point not callable</title>
<updated>2016-07-28T18:49:58+00:00</updated>
<author>
<name>Marc Abramowitz</name>
<email>marc@marc-abramowitz.com</email>
</author>
<published>2016-07-28T18:49:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=d234f22e09209d586501a9f8cbd03873aedeba62'/>
<id>d234f22e09209d586501a9f8cbd03873aedeba62</id>
<content type='text'>
E.g.:

```
$ .tox/flake8/bin/flake8 mobileweb
Traceback (most recent call last):
  File ".tox/flake8/bin/flake8", line 9, in &lt;module&gt;
    load_entry_point('flake8', 'console_scripts', 'flake8')()
  File "/Users/marca/dev/git-repos/flake8/src/flake8/main/cli.py", line 16, in main
    app.run(argv)
  File "/Users/marca/dev/git-repos/flake8/src/flake8/main/application.py", line 316, in run
    self._run(argv)
  File "/Users/marca/dev/git-repos/flake8/src/flake8/main/application.py", line 299, in _run
    self.initialize(argv)
  File "/Users/marca/dev/git-repos/flake8/src/flake8/main/application.py", line 289, in initialize
    self.find_plugins()
  File "/Users/marca/dev/git-repos/flake8/src/flake8/main/application.py", line 143, in find_plugins
    self.check_plugins.load_plugins()
  File "/Users/marca/dev/git-repos/flake8/src/flake8/plugins/manager.py", line 375, in load_plugins
    plugins = list(self.manager.map(load_plugin))
  File "/Users/marca/dev/git-repos/flake8/src/flake8/plugins/manager.py", line 267, in map
    yield func(self.plugins[name], *args, **kwargs)
  File "/Users/marca/dev/git-repos/flake8/src/flake8/plugins/manager.py", line 373, in load_plugin
    return plugin.load_plugin()
  File "/Users/marca/dev/git-repos/flake8/src/flake8/plugins/manager.py", line 173, in load_plugin
    raise failed_to_load
flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin "P999" due to Plugin &lt;module 'teamcity.flake8_plugin' from '/Users/marca/dev/git-repos/teamcity-messages/teamcity/flake8_plugin.pyc'&gt; is not a callable. It might be written for an older version of flake8 and might not work with this version.
```

This is nicer than the previous behavior of raising an obscure `PicklingError` and then hanging.

```
$ .tox/flake8/bin/flake8 mobileweb
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/queues.py", line 268, in _feed
    send(obj)
PicklingError: Can't pickle &lt;type 'module'&gt;: attribute lookup __builtin__.module failed
```

See #164
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
E.g.:

```
$ .tox/flake8/bin/flake8 mobileweb
Traceback (most recent call last):
  File ".tox/flake8/bin/flake8", line 9, in &lt;module&gt;
    load_entry_point('flake8', 'console_scripts', 'flake8')()
  File "/Users/marca/dev/git-repos/flake8/src/flake8/main/cli.py", line 16, in main
    app.run(argv)
  File "/Users/marca/dev/git-repos/flake8/src/flake8/main/application.py", line 316, in run
    self._run(argv)
  File "/Users/marca/dev/git-repos/flake8/src/flake8/main/application.py", line 299, in _run
    self.initialize(argv)
  File "/Users/marca/dev/git-repos/flake8/src/flake8/main/application.py", line 289, in initialize
    self.find_plugins()
  File "/Users/marca/dev/git-repos/flake8/src/flake8/main/application.py", line 143, in find_plugins
    self.check_plugins.load_plugins()
  File "/Users/marca/dev/git-repos/flake8/src/flake8/plugins/manager.py", line 375, in load_plugins
    plugins = list(self.manager.map(load_plugin))
  File "/Users/marca/dev/git-repos/flake8/src/flake8/plugins/manager.py", line 267, in map
    yield func(self.plugins[name], *args, **kwargs)
  File "/Users/marca/dev/git-repos/flake8/src/flake8/plugins/manager.py", line 373, in load_plugin
    return plugin.load_plugin()
  File "/Users/marca/dev/git-repos/flake8/src/flake8/plugins/manager.py", line 173, in load_plugin
    raise failed_to_load
flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin "P999" due to Plugin &lt;module 'teamcity.flake8_plugin' from '/Users/marca/dev/git-repos/teamcity-messages/teamcity/flake8_plugin.pyc'&gt; is not a callable. It might be written for an older version of flake8 and might not work with this version.
```

This is nicer than the previous behavior of raising an obscure `PicklingError` and then hanging.

```
$ .tox/flake8/bin/flake8 mobileweb
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/queues.py", line 268, in _feed
    send(obj)
PicklingError: Can't pickle &lt;type 'module'&gt;: attribute lookup __builtin__.module failed
```

See #164
</pre>
</div>
</content>
</entry>
<entry>
<title>Sort reports by line and column</title>
<updated>2016-07-28T17:25:13+00:00</updated>
<author>
<name>Fabian Neundorf</name>
<email>CommodoreFabianus@gmx.de</email>
</author>
<published>2016-07-28T17:25:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=ad3b4869095dc589c4c72982a101e6bdd6b5c87e'/>
<id>ad3b4869095dc589c4c72982a101e6bdd6b5c87e</id>
<content type='text'>
Originally the reports have been sorted by column and message (without the
error code), so it didn't order after the line number.

Closes #196
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Originally the reports have been sorted by column and message (without the
error code), so it didn't order after the line number.

Closes #196
</pre>
</div>
</content>
</entry>
<entry>
<title>Match noqa for users with explanations</title>
<updated>2016-07-28T11:48:15+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2016-07-28T11:25:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=c0ddc54f2f5e3f453735780e639be08ef3b15e2d'/>
<id>c0ddc54f2f5e3f453735780e639be08ef3b15e2d</id>
<content type='text'>
This makes the regular expression a bit more complex, and potentially
slower, but it will fix the issue where users had noqa comments with
colons followed by explanations.

Closes #178
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This makes the regular expression a bit more complex, and potentially
slower, but it will fix the issue where users had noqa comments with
colons followed by explanations.

Closes #178
</pre>
</div>
</content>
</entry>
<entry>
<title>Handle AttributeErrors during parameter aggregation</title>
<updated>2016-07-27T12:17:29+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2016-07-27T12:17:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=47e3e65cc1734e46fd16ea11622e57b7978d3e0d'/>
<id>47e3e65cc1734e46fd16ea11622e57b7978d3e0d</id>
<content type='text'>
Plugins do not have their parameters checked in advance, so when we
try to aggregate parameters for a plugin, there's a chance it may
request an attribute of the FileProcessor that simply does not exist.

We catch this and re-raise it but we should also capture it in the
checker manager and handle it appropriately there as well.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Plugins do not have their parameters checked in advance, so when we
try to aggregate parameters for a plugin, there's a chance it may
request an attribute of the FileProcessor that simply does not exist.

We catch this and re-raise it but we should also capture it in the
checker manager and handle it appropriately there as well.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-mp-win-3.0' into 'master'</title>
<updated>2016-07-27T11:43:51+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2016-07-27T11:43:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=846bfafe6c63870f41bac0eadf41b2a0a85c85aa'/>
<id>846bfafe6c63870f41bac0eadf41b2a0a85c85aa</id>
<content type='text'>

Fix multiprocessing on Windows

*Related to:*  #184 

I'm still running into #179 with this fix but all processes start now at least.

BTW the current design is pretty bad regarding memory footprint and bootstrap time as you have to pickle the manager object for *every* subprocess. So this does not only fix multiprocessing on Windows. It improves the multiprocessing design on other platforms, too.

See merge request !97</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix multiprocessing on Windows

*Related to:*  #184 

I'm still running into #179 with this fix but all processes start now at least.

BTW the current design is pretty bad regarding memory footprint and bootstrap time as you have to pickle the manager object for *every* subprocess. So this does not only fix multiprocessing on Windows. It improves the multiprocessing design on other platforms, too.

See merge request !97</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '_job_count_rettype' into 'master'</title>
<updated>2016-07-27T11:26:11+00:00</updated>
<author>
<name>Ian Cordasco</name>
<email>graffatcolmingov@gmail.com</email>
</author>
<published>2016-07-27T11:26:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=d258becbe4ea5644ac57ba0f9542604aa30cb7ed'/>
<id>d258becbe4ea5644ac57ba0f9542604aa30cb7ed</id>
<content type='text'>

_job_count always returns an int

Trivial change, but `_job_count` always returns an `int`.

See merge request !95</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

_job_count always returns an int

Trivial change, but `_job_count` always returns an `int`.

See merge request !95</pre>
</div>
</content>
</entry>
<entry>
<title>Fix multiprocessing on Windows</title>
<updated>2016-07-27T06:09:06+00:00</updated>
<author>
<name>schlamar</name>
<email>marc.schlaich@gmail.com</email>
</author>
<published>2016-07-27T06:09:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/python-packages/flake8.git/commit/?id=1f10ed687e964c64b9eea2ee05e6fea8054c887b'/>
<id>1f10ed687e964c64b9eea2ee05e6fea8054c887b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
