From 14bbb9ce8865dd41465f85a1fce23989b5cb3cd0 Mon Sep 17 00:00:00 2001 From: Bob Halley Date: Mon, 4 Jan 2021 12:17:36 -0800 Subject: _WireReader.read() should make flags a dns.flags.Flag [Issue #606] --- dns/message.py | 2 +- tests/test_message.py | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/dns/message.py b/dns/message.py index 428c98e..ac88837 100644 --- a/dns/message.py +++ b/dns/message.py @@ -990,7 +990,7 @@ class _WireReader: self.parser.get_struct('!HHHHHH') factory = _message_factory_from_opcode(dns.opcode.from_flags(flags)) self.message = factory(id=id) - self.message.flags = flags + self.message.flags = dns.flags.Flag(flags) self.initialize_message(self.message) self.one_rr_per_rrset = \ self.message._get_one_rr_per_rrset(self.one_rr_per_rrset) diff --git a/tests/test_message.py b/tests/test_message.py index ed48e7b..19738e6 100644 --- a/tests/test_message.py +++ b/tests/test_message.py @@ -676,6 +676,11 @@ flags QR IN SOA ''') + def test_from_wire_makes_Flag(self): + m = dns.message.from_wire(goodwire) + self.assertIsInstance(m.flags, dns.flags.Flag) + self.assertEqual(m.flags, dns.flags.Flag.RD) + if __name__ == '__main__': unittest.main() -- cgit v1.2.1