From ece18207cbb64dd89014e279ac636a6c9829828e Mon Sep 17 00:00:00 2001 From: Tim Park Date: Sat, 29 Aug 2020 12:17:58 -0700 Subject: Fixed #31858 -- Reallowed whitespaces in URL paths outside of parameters. Regression in 22394bd3a18a7d9a8957a0b431f8ae4e5ca03a8c. Thanks David Smith for the review. --- tests/urlpatterns/tests.py | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) (limited to 'tests/urlpatterns') diff --git a/tests/urlpatterns/tests.py b/tests/urlpatterns/tests.py index 54b7e09813..b6b23ade9e 100644 --- a/tests/urlpatterns/tests.py +++ b/tests/urlpatterns/tests.py @@ -1,3 +1,4 @@ +import string import uuid from django.conf.urls import url as conf_url @@ -142,10 +143,19 @@ class SimplifiedURLTests(SimpleTestCase): with self.assertRaisesMessage(ImproperlyConfigured, msg): path('foo//', empty_view) - def test_space_in_route(self): - msg = "URL route 'space/' cannot contain whitespace." - with self.assertRaisesMessage(ImproperlyConfigured, msg): - path('space/', empty_view) + def test_whitespace_in_route(self): + msg = ( + "URL route 'space//extra/' cannot contain " + "whitespace in angle brackets <…>" + ) + for whitespace in string.whitespace: + with self.subTest(repr(whitespace)): + with self.assertRaisesMessage(ImproperlyConfigured, msg % whitespace): + path('space//extra/' % whitespace, empty_view) + # Whitespaces are valid in paths. + p = path('space%s//' % string.whitespace, empty_view) + match = p.resolve('space%s/1/' % string.whitespace) + self.assertEqual(match.kwargs, {'num': 1}) @override_settings(ROOT_URLCONF='urlpatterns.converter_urls') -- cgit v1.2.1