From 806e9e2d0dcf8f58e376fb7e2a8b9771e2a9ce16 Mon Sep 17 00:00:00 2001 From: David Wobrock Date: Wed, 24 Aug 2022 21:14:32 +0200 Subject: Fixed #33952 -- Reallowed creating reverse foreign key managers on unsaved instances. Thanks Claude Paroz for the report. Regression in 7ba6ebe9149ae38257d70100e8bfbfd0da189862. --- django/db/models/fields/related_descriptors.py | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) (limited to 'django/db/models/fields') diff --git a/django/db/models/fields/related_descriptors.py b/django/db/models/fields/related_descriptors.py index 6e9f7bccbf..e61ee077f0 100644 --- a/django/db/models/fields/related_descriptors.py +++ b/django/db/models/fields/related_descriptors.py @@ -647,15 +647,6 @@ def create_reverse_many_to_one_manager(superclass, rel): self.core_filters = {self.field.name: instance} - # Even if this relation is not to pk, we require still pk value. - # The wish is that the instance has been already saved to DB, - # although having a pk value isn't a guarantee of that. - if self.instance.pk is None: - raise ValueError( - f"{instance.__class__.__name__!r} instance needs to have a primary " - f"key value before this relationship can be used." - ) - def __call__(self, *, manager): manager = getattr(self.model, manager) manager_class = create_reverse_many_to_one_manager(manager.__class__, rel) @@ -720,6 +711,14 @@ def create_reverse_many_to_one_manager(superclass, rel): pass # nothing to clear from cache def get_queryset(self): + # Even if this relation is not to pk, we require still pk value. + # The wish is that the instance has been already saved to DB, + # although having a pk value isn't a guarantee of that. + if self.instance.pk is None: + raise ValueError( + f"{self.instance.__class__.__name__!r} instance needs to have a " + f"primary key value before this relationship can be used." + ) try: return self.instance._prefetched_objects_cache[ self.field.remote_field.get_cache_name() -- cgit v1.2.1