From 9b9f3befeda88c84e9fae6f307615656f4eed9bd Mon Sep 17 00:00:00 2001 From: liuqing Date: Tue, 1 Jul 2014 16:34:16 +0800 Subject: Use immutable arg rather mutable arg Passing mutable objects as default args is a known Python pitfall. We'd better avoid this. This commit changes mutable default args with None. Change-Id: I78323383c8b6a9a516a2a217303124870822418b --- glanceclient/common/utils.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'glanceclient/common/utils.py') diff --git a/glanceclient/common/utils.py b/glanceclient/common/utils.py index 6cdc364..58c0ded 100644 --- a/glanceclient/common/utils.py +++ b/glanceclient/common/utils.py @@ -45,7 +45,8 @@ def arg(*args, **kwargs): return _decorator -def schema_args(schema_getter, omit=[]): +def schema_args(schema_getter, omit=None): + omit = omit or [] typemap = { 'string': str, 'integer': int, @@ -104,7 +105,8 @@ def pretty_choice_list(l): return ', '.join("'%s'" % i for i in l) -def print_list(objs, fields, formatters={}): +def print_list(objs, fields, formatters=None): + formatters = formatters or {} pt = prettytable.PrettyTable([f for f in fields], caching=False) pt.align = 'l' -- cgit v1.2.1