From 73c6213e8b47fa7c4c2c7a517fe7b56126145888 Mon Sep 17 00:00:00 2001 From: Simon Feltman Date: Thu, 26 Sep 2013 19:05:20 -0700 Subject: Don't pass None to callbacks when user data is not specified For APIs which support a callback and optional user data, don't pass the user data to the callback if it was not explicitly specified when the callback was connected. https://bugzilla.gnome.org/show_bug.cgi?id=640812 --- tests/test_everything.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'tests/test_everything.py') diff --git a/tests/test_everything.py b/tests/test_everything.py index 0c6533a8..ab1fc487 100644 --- a/tests/test_everything.py +++ b/tests/test_everything.py @@ -717,12 +717,10 @@ class TestCallbacks(unittest.TestCase): self.assertEqual(TestCallbacks.called, 100) - def test_callback_userdata_none_default_arg(self): + def test_callback_userdata_no_user_data(self): TestCallbacks.called = 0 - userdata_list = [] - def callback(userdata): - userdata_list.append(userdata) + def callback(): TestCallbacks.called += 1 return TestCallbacks.called @@ -731,7 +729,6 @@ class TestCallbacks(unittest.TestCase): self.assertEqual(val, i + 1) self.assertEqual(TestCallbacks.called, 100) - self.assertSequenceEqual(userdata_list, [None] * 100) def test_async_ready_callback(self): TestCallbacks.called = False -- cgit v1.2.1