From deb3abcd8a11328979ac31c4e48a3754c4b4b37f Mon Sep 17 00:00:00 2001 From: Rui Matos Date: Thu, 21 May 2015 17:53:17 +0200 Subject: Avoid a silent long to int truncation If the python object contains a value bigger than MAXUINT we'd silently truncate it when assigning to 'val' and the if condition would always be true. This was caught by a coverity scan. https://bugzilla.gnome.org/show_bug.cgi?id=749698 --- gi/pygi-value.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gi/pygi-value.c b/gi/pygi-value.c index 9d5d0caf..7fdf7675 100644 --- a/gi/pygi-value.c +++ b/gi/pygi-value.c @@ -382,7 +382,7 @@ pyg_value_from_pyobject_with_error(GValue *value, PyObject *obj) case G_TYPE_UINT: { if (PYGLIB_PyLong_Check(obj)) { - guint val; + gulong val; /* check that number is not negative */ if (PyLong_AsLongLong(obj) < 0) @@ -390,7 +390,7 @@ pyg_value_from_pyobject_with_error(GValue *value, PyObject *obj) val = PyLong_AsUnsignedLong(obj); if (val <= G_MAXUINT) - g_value_set_uint(value, val); + g_value_set_uint(value, (guint) val); else return -1; } else { -- cgit v1.2.1