delta/postgresql.git/src, branch master git.postgresql.org: git/postgresql.git ICU: check for U_STRING_NOT_TERMINATED_WARNING. 2023-05-17T21:18:45+00:00 Jeff Davis jdavis@postgresql.org 2023-05-17T20:43:41+00:00 1c634f6647c28354258d114041252475325aea32 Fixes memory error in cases where the length of the language name returned by uloc_getLanguage() is exactly ULOC_LANG_CAPACITY, in which case the status is set to U_STRING_NOT_TERMINATED_WARNING. Also check in call sites for other ICU functions that are expected to return a C string to be safe (no bug is known at these other call sites). Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/2098874d-c111-41e4-9063-30bcf135226b@gmail.com 
Fixes memory error in cases where the length of the language name
returned by uloc_getLanguage() is exactly ULOC_LANG_CAPACITY, in which
case the status is set to U_STRING_NOT_TERMINATED_WARNING.

Also check in call sites for other ICU functions that are expected to
return a C string to be safe (no bug is known at these other call
sites).

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/2098874d-c111-41e4-9063-30bcf135226b@gmail.com
Reduce icu_validation_level default to WARNING. 2023-05-17T20:18:40+00:00 Jeff Davis jdavis@postgresql.org 2023-05-17T20:18:40+00:00 6de31ce446e59a1f947c7ebe4e4bbe7ca2b842bc Discussion: https://postgr.es/m/daa9f060aa2349ebc84444515efece49e7b32c5d.camel@j-davis.com 
Discussion: https://postgr.es/m/daa9f060aa2349ebc84444515efece49e7b32c5d.camel@j-davis.com
Fix error message wordings 2023-05-17T19:33:47+00:00 Peter Eisentraut peter@eisentraut.org 2023-05-17T19:33:13+00:00 009bd237bf6db64ea1131df71f19a529b119fbef The original patch for percentrepl.c c96de2ce17 adopted the error messages from basebackup_to_shell, but that uses terminology that doesn't really fit with the new API naming. 
The original patch for percentrepl.c c96de2ce17 adopted the error
messages from basebackup_to_shell, but that uses terminology that
doesn't really fit with the new API naming.
Add writeback to pg_stat_io 2023-05-17T18:18:35+00:00 Andres Freund andres@anarazel.de 2023-05-17T18:18:35+00:00 093e5c57d506783a95dd8feddd9a3f2651e1aeba 28e626bde00 added the concept of IOOps but neglected to include writeback operations. ac8d53dae5 added time spent doing these I/O operations. Without counting writeback, checkpointer write time in the log often differed substantially from that in pg_stat_io. To fix this, add IOOp IOOP_WRITEBACK and track writeback in pg_stat_io. Bumps catversion. Author: Melanie Plageman <melanieplageman@gmail.com> Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com> Reported-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20230419172326.dhgyo4wrrhulovt6%40awork3.anarazel.de 
28e626bde00 added the concept of IOOps but neglected to include writeback
operations. ac8d53dae5 added time spent doing these I/O operations. Without
counting writeback, checkpointer write time in the log often differed
substantially from that in pg_stat_io. To fix this, add IOOp IOOP_WRITEBACK
and track writeback in pg_stat_io.

Bumps catversion.

Author: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reported-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20230419172326.dhgyo4wrrhulovt6%40awork3.anarazel.de
Update parameter name context to wb_context 2023-05-17T18:18:30+00:00 Andres Freund andres@anarazel.de 2023-05-17T18:17:12+00:00 52676dc2e016df5cd842a4f6073b25ee8e681b9f For clarity of review, renaming the function parameter "context" in ScheduleBufferTagForWriteback() and IssuePendingWritebacks() to "wb_context" is a separate commit. The next commit adds an "io_context" parameter and "wb_context" makes it more clear which is which. Author: Melanie Plageman <melanieplageman@gmail.com> Discussion: https://postgr.es/m/CAAKRu_acc6iL4M3hvOTeztf_ZPpsB3Pqio5aVHgZ5q=Pi3BZKg@mail.gmail.com 
For clarity of review, renaming the function parameter "context" in
ScheduleBufferTagForWriteback() and IssuePendingWritebacks() to
"wb_context" is a separate commit. The next commit adds an "io_context"
parameter and "wb_context" makes it more clear which is which.

Author: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://postgr.es/m/CAAKRu_acc6iL4M3hvOTeztf_ZPpsB3Pqio5aVHgZ5q=Pi3BZKg@mail.gmail.com
Use BUFFER_USAGE_LIMIT to reduce needed test table size 2023-05-17T18:17:41+00:00 Andres Freund andres@anarazel.de 2023-05-17T18:17:02+00:00 322875597c0c15cd85d03c8621038f4945c8caa3 Using the minimum BUFFER_USAGE_LIMIT value, we can make one of the pg_stat_io test tables smaller while still causing reuses. Author: Melanie Plageman <melanieplageman@gmail.com> Discussion: https://postgr.es/m/CAAKRu_acc6iL4M3hvOTeztf_ZPpsB3Pqio5aVHgZ5q=Pi3BZKg@mail.gmail.com 
Using the minimum BUFFER_USAGE_LIMIT value, we can make one of the pg_stat_io
test tables smaller while still causing reuses.

Author: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://postgr.es/m/CAAKRu_acc6iL4M3hvOTeztf_ZPpsB3Pqio5aVHgZ5q=Pi3BZKg@mail.gmail.com
Revert "Add USER SET parameter values for pg_db_role_setting" 2023-05-17T17:28:57+00:00 Alexander Korotkov akorotkov@postgresql.org 2023-05-17T17:06:50+00:00 b9a7a822723aebb16cbe7e5fb874e5124745b07e This reverts commit 096dd80f3ccc and its fixups beecbe8e5001, afdd9f7f0e00, 529da086ba, db93e739ac61. Catversion is bumped. Discussion: https://postgr.es/m/d46f9265-ff3c-6743-2278-6772598233c2%40pgmasters.net 
This reverts commit 096dd80f3ccc and its fixups beecbe8e5001, afdd9f7f0e00,
529da086ba, db93e739ac61.

Catversion is bumped.

Discussion: https://postgr.es/m/d46f9265-ff3c-6743-2278-6772598233c2%40pgmasters.net
pg_dump: Error message improvements 2023-05-17T17:13:08+00:00 Alvaro Herrera alvherre@alvh.no-ip.org 2023-05-17T17:13:08+00:00 58dc80acc5ebf12223be90db1a97dc0b31ca4e1f Remove spurious semicolon from one error message, and print the offending value of a parameter reported as invalid in another. 
Remove spurious semicolon from one error message, and print the
offending value of a parameter reported as invalid in another.
pg_dump: Have _EndLO report errno after CFH->write_func() failure 2023-05-17T16:55:51+00:00 Alvaro Herrera alvherre@alvh.no-ip.org 2023-05-17T16:55:51+00:00 98bd4c72fd6c4f9d6a2b3b449cb89f335116ab5a Other callers of that function do things this way, but this one didn't get the memo. 
Other callers of that function do things this way, but this one didn't
get the memo.
Track tlist_vinfo.varnullingrels even in non-Assert builds. 2023-05-17T15:46:15+00:00 Tom Lane tgl@sss.pgh.pa.us 2023-05-17T15:46:15+00:00 69c430626b5eb44825a12e8bc90a59a90c4f5a03 Oversight in commit 867be9c07 (which should get reverted along with that, if we ever do revert it). Per buildfarm. 
Oversight in commit 867be9c07 (which should get reverted
along with that, if we ever do revert it).  Per buildfarm.