delta/pidgin.git, branch master

Use G_SOURCE_FUNC macro more

2023-04-30T22:42:35+00:00

It was added in GLib 2.58

Testing Done:
Compiled only.

Reviewed at https://reviews.imfreedom.org/r/2446/

Fix account request field in Pidgin when filtering

2023-04-25T20:00:33+00:00

The field is set to its default value first, filtered, then a notify signal is connected. If the filter excludes the default, then the notification is not fired at this point.

So if there's a filter that excludes that default and you don't change the selection from the UI, then nothing will have told the field that the default is not the selection, and the field result will not match what the user thought they selected.

Testing Done:
Tried a few times in the I'dle Mak'er plugin.

Previously, if accounts loaded such that a Demo account is before an XMPP account, then even though the XMPP account appeared in the selector initially, the idle would be attempted on the Demo account. Now it is always the XMPP account as expected from the UI.

Reviewed at https://reviews.imfreedom.org/r/2443/

Make PurpleRequestFieldAccount work like a GtkCustomFilter

2023-04-25T06:02:47+00:00

This makes the filtering better for introspection.

Also, fixed an incorrect type check.

Testing Done:
Enabled Demo and XMPP accounts, then tried the I'dle Mak'er plugin and confirmed that only XMPP showed in its "Set Account Idle Time" action request.

Bugs closed: PIDGIN-17780

Reviewed at https://reviews.imfreedom.org/r/2442/

Create PurpleSavedPresence for saving the users presences

2023-04-25T05:46:17+00:00

Testing Done:
Ran the unit tests.

Bugs closed: PIDGIN-17795

Reviewed at https://reviews.imfreedom.org/r/2440/

Remove unused CSS file

2023-04-19T03:44:01+00:00

I see no reference to the file, nor any of the classes it uses.

Testing Done:
Compile only.

Reviewed at https://reviews.imfreedom.org/r/2438/

Don't duplicate contacts in the demo protocol when reconnecting

2023-04-19T02:19:39+00:00

Previously, we were always creating new contacts and persons on connection. This
ends up with duplicates when we run the connection error actions which is
obviously not what we want.

Testing Done:
Ran the connection error actions and verified that we did not get duplicate contacts and persons.

Reviewed at https://reviews.imfreedom.org/r/2436/

Port the demo protocol's actions to the new status api

2023-04-13T20:55:28+00:00

Testing Done:
Trigger temporary and fatal connection errors and verified that my status message was updated for them.

Bugs closed: PIDGIN-17790

Reviewed at https://reviews.imfreedom.org/r/2435/

Port the demo protocol plugin to contacts

2023-04-11T23:10:40+00:00

Testing Done:
Deleted the old `blist.xml` from my `XDG_CONFIG_HOME` and verified that I only got the new contacts and verified that they were not stored back to `blist.xml`.

Reviewed at https://reviews.imfreedom.org/r/2432/

Use gtk_widget_set_visible for everything

2023-04-11T05:17:15+00:00

gtk_widget_show and gtk_widget_hide are deprecated in GTK 4.10. However,
gtk_widget_set_visible has been around forever so we just need to move to that.

I didn't test all of these and there are probably some that can still be
removed, but most of those are in code that is going to get refreshed in the
future so I didn't bother for now.

Testing Done:
I tested the join chat, add chat, and add buddy dialogs, as well as the contact added notification.

Reviewed at https://reviews.imfreedom.org/r/2430/

Fix the issue where the contact list would sometimes duplicate everyone

2023-04-11T04:47:15+00:00

Testing Done:
This was tested with another review request that was reproducing it 100% of the time.

Reviewed at https://reviews.imfreedom.org/r/2431/