From c7a1d96f8a3f89c42bbb6bd16eca1d36cc11d579 Mon Sep 17 00:00:00 2001 From: Markus Fischer Date: Sat, 13 Apr 2002 05:06:33 +0000 Subject: - Fix a possible memory leak in xml_set_handler(). I stumbled over this while trying out 'pear package' which, while doing xml parsing, re-assigns the variaous callback handlers depending on the version during xml processing. If this check causes problems, let me know. --- ext/xml/xml.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'ext/xml/xml.c') diff --git a/ext/xml/xml.c b/ext/xml/xml.c index a6ee1aec60..ce87d36139 100644 --- a/ext/xml/xml.c +++ b/ext/xml/xml.c @@ -354,6 +354,11 @@ static void xml_set_handler(zval **handler, zval **data) convert_to_string_ex(data); } + /* If we have already a handler, release it */ + if (*handler) { + zval_ptr_dtor(handler); + } + zval_add_ref(data); *handler = *data; } -- cgit v1.2.1