From b10416a652d26577a22fe0b183b2258b20c8bb86 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Mon, 30 Nov 2020 16:45:48 +0100 Subject: Deprecate passing null to non-nullable arg of internal function This deprecates passing null to non-nullable scale arguments of internal functions, with the eventual goal of making the behavior consistent with userland functions, where null is never accepted for non-nullable arguments. This change is expected to cause quite a lot of fallout. In most cases, calling code should be adjusted to avoid passing null. In some cases, PHP should be adjusted to make some function arguments nullable. I have already fixed a number of functions before landing this, but feel free to file a bug if you encounter a function that doesn't accept null, but probably should. (The rule of thumb for this to be applicable is that the function must have special behavior for 0 or "", which is distinct from the natural behavior of the parameter.) RFC: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg Closes GH-6475. --- ext/session/tests/bug69111.phpt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ext/session') diff --git a/ext/session/tests/bug69111.phpt b/ext/session/tests/bug69111.phpt index c7a6cada65..7dff0590dd 100644 --- a/ext/session/tests/bug69111.phpt +++ b/ext/session/tests/bug69111.phpt @@ -14,7 +14,7 @@ $sessionName = ini_get('session.name'); $sh->open($savePath, $sessionName); $sh->write("foo", "bar"); -var_dump($sh->read(@$id)); +var_dump($sh->read("")); ?> --EXPECTF-- Warning: SessionHandler::open(): Session is not active in %s on line 10 -- cgit v1.2.1