From 4e7064d173d2b5b22e159fcf52d22b10213b67b8 Mon Sep 17 00:00:00 2001 From: Peter Kokot Date: Wed, 13 Mar 2019 00:25:07 +0100 Subject: Move acinclude.m4 to build/php.m4 The acinclude.m4 file is in a usual Autotools build processed with Automake's aclocal tool. Since PHP currently doesn't use Automake and aclocal this file can be moved into the build directory. PHP build system currently generates a combined aclocal.m4 file that Autoconf can processes automatically. However, a newer practice is writing all local macros in separate dedicated files prefixed with package name, in PHP's case PHP_MACRO_NAME and putting them in a common `m4` directory. PHP uses currently `build` directory for this purpose. Name `php.m4` probably most resembles such file for PHP's case. PHP manually created the aclocal.m4 file from acinclude.m4 and build/libtool.m4. Which is also not a particularly good practice [1], so this patch also removes the generated alocal.m4 usage and uses m4_include() calls manually in the configure.ac and phpize.m4 files manually. - sort order is not important but can be alphabetical - list of *.m4 files prerequisites for configure script generation updated - Moving m4_include() before AC_INIT also removes all comments starting with hash character (`#`) in the included files. [1] https://autotools.io/autoconf/macros.html --- docs/unix-build-system.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'docs') diff --git a/docs/unix-build-system.md b/docs/unix-build-system.md index bdb8d4d146..c576b5e075 100644 --- a/docs/unix-build-system.md +++ b/docs/unix-build-system.md @@ -53,7 +53,7 @@ The full syntax: PHP_NEW_EXTENSION(extname, sources [, shared [,sapi_class[, extra-cflags]]]) ``` -Please have a look at `acinclude.m4` for the gory details and meanings of the +Please have a look at `build/php.m4` for the gory details and meanings of the other parameters. And that's basically it for the extension side. @@ -118,4 +118,4 @@ contexts. With the help of macros you can define special flags for each source-file, where it is located, in which target context it can work, etc. Have a look at the well documented macros `PHP_ADD_SOURCES(_X)` in -`acinclude.m4`. +`build/php.m4`. -- cgit v1.2.1