From 3a031e0b03f11b40b8b374472336d9a6df4d81b8 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Wed, 27 May 2020 12:01:16 +0200 Subject: Drop hard-coded /W3 default in favor of custom CFLAGS Building with `/W3` shows an awful lot of warnings on Windows, so it's really hard to spot the more important ones. Since it is not possible to override the hard-coded `/W3`, we drop it altogether, so MSVC uses the default `/W1`. Users are encouraged to increase the warning level via the environment variable `CFLAGS` before doing configure. We also enable `/WX` (treat warnings as errors) for AppVeyor CI, using `/W1` for now, since otherwise the build would fail. --- appveyor/build_task.bat | 2 ++ 1 file changed, 2 insertions(+) (limited to 'appveyor') diff --git a/appveyor/build_task.bat b/appveyor/build_task.bat index 124968fe14..91fedae855 100644 --- a/appveyor/build_task.bat +++ b/appveyor/build_task.bat @@ -54,6 +54,8 @@ if "%INTRINSICS%" neq "" set ADD_CONF=%ADD_CONF% --enable-native-intrinsics=%INT set EXT_EXCLUDE_FROM_TEST=snmp,oci8_12c,pdo_oci,pdo_firebird,ldap,imap,ftp if "%OPCACHE%" equ "0" set EXT_EXCLUDE_FROM_TEST=%EXT_EXCLUDE_FROM_TEST%,opcache +set CFLAGS=/W1 /WX + cmd /c configure.bat ^ --enable-snapshot-build ^ --disable-debug-pack ^ -- cgit v1.2.1