From 62938bf08806129b42b17e74d79a450c30d4ff30 Mon Sep 17 00:00:00 2001 From: jhdxr Date: Mon, 30 Jan 2017 17:48:00 +0800 Subject: fix BC break introduced by #2346 (sebastianbergmann/phpunit#2454) --- ext/dom/document.c | 3 +++ ext/dom/tests/DOMDocument_savexml_basic2.phpt | 33 +++++++++++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 ext/dom/tests/DOMDocument_savexml_basic2.phpt diff --git a/ext/dom/document.c b/ext/dom/document.c index c7e4f8e7a5..d8e950d2c1 100644 --- a/ext/dom/document.c +++ b/ext/dom/document.c @@ -1628,6 +1628,9 @@ PHP_FUNCTION(dom_document_savexml) doc_props = dom_get_doc_props(intern->document); format = doc_props->formatoutput; + if (format) { + options = options | XML_SAVE_FORMAT; + } buf = xmlBufferCreate(); if (!buf) { diff --git a/ext/dom/tests/DOMDocument_savexml_basic2.phpt b/ext/dom/tests/DOMDocument_savexml_basic2.phpt new file mode 100644 index 0000000000..7c01014808 --- /dev/null +++ b/ext/dom/tests/DOMDocument_savexml_basic2.phpt @@ -0,0 +1,33 @@ +--TEST-- +DOM Document: saveXML with createElement and formatOutput +--CREDITS-- +CHU Zhaowei +--SKIPIF-- + +--FILE-- +formatOutput = true; + +$root = $dom->createElement('root'); +$dom->appendChild($root); + +$child1 = $dom->createElement('testsuite'); +$root->appendChild($child1); + +$child11 = $dom->createElement('testcase'); +$child11->setAttribute('name', 'leaf1'); +$child12 = $dom->createElement('testcase'); +$child12->setAttribute('name', 'leaf2'); +$child1->appendChild($child11); +$child1->appendChild($child12); + +echo $dom->saveXml(); +--EXPECT-- + + + + + + + \ No newline at end of file -- cgit v1.2.1