From 2ab934bfc20edbc6442b76c90d214ba24bca3e5c Mon Sep 17 00:00:00 2001 From: Stig Bakken Date: Wed, 21 Jul 1999 14:27:05 +0000 Subject: fix to reiterate that one should _always_ use braces around if/else/for/while --- ext/standard/base64.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ext/standard/base64.c b/ext/standard/base64.c index 32c63a36c4..d0a565fde4 100644 --- a/ext/standard/base64.c +++ b/ext/standard/base64.c @@ -74,18 +74,21 @@ unsigned char *_php3_base64_decode(const unsigned char *string, int length, int /* this sucks for threaded environments */ static short reverse_table[256]; static int table_built; + unsigned char *result; - if(++table_built == 1) { + if (++table_built == 1) { char *chp; for(ch = 0; ch < 256; ch++) { chp = strchr(base64_table, ch); - if(chp) + if(chp) { reverse_table[ch] = chp - base64_table; - else + } else { reverse_table[ch] = -1; + } + } } - unsigned char *result = (unsigned char *)emalloc((length / 4 * 3 + 1) * sizeof(char)); + result = (unsigned char *)emalloc((length / 4 * 3 + 1) * sizeof(char)); if (result == NULL) { return NULL; } -- cgit v1.2.1