From 2816a3fdfa23cf0711251b8d1e9ffad3d281ea96 Mon Sep 17 00:00:00 2001
From: "Christoph M. Becker" <cmbecker69@gmx.de>
Date: Tue, 30 Oct 2018 18:53:03 +0100
Subject: Fix and improve test case

We fix the erroneous doctype declaration, clarify the expectation, and
add a comment to clarify the purpose of the tag mismatch in the XML.
---
 ext/xml/tests/bug71592.phpt | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/ext/xml/tests/bug71592.phpt b/ext/xml/tests/bug71592.phpt
index 28a316a28e..e76e7b4ef6 100644
--- a/ext/xml/tests/bug71592.phpt
+++ b/ext/xml/tests/bug71592.phpt
@@ -6,9 +6,11 @@ if (!extension_loaded('xml')) die('skip xml extension not available');
 ?>
 --FILE--
 <?php
+// The tag mismatch at the end of the XML is on purpose, to make sure that the
+// parser actually stops after the handler returns FALSE.
 $xml = <<<XML
 <?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE p [
+<!DOCTYPE root [
   <!ENTITY pic PUBLIC "image.gif" "http://example.org/image.gif">
 ]>
 <root>
@@ -22,9 +24,9 @@ xml_set_external_entity_ref_handler($parser, function () {
     return false;
 });
 xml_parse($parser, $xml);
-var_dump(xml_get_error_code($parser));
+var_dump(xml_get_error_code($parser) === XML_ERROR_EXTERNAL_ENTITY_HANDLING);
 ?>
 ===DONE===
 --EXPECT--
-int(21)
+bool(true)
 ===DONE===
-- 
cgit v1.2.1