summaryrefslogtreecommitdiff
path: root/sapi
diff options
context:
space:
mode:
authorMoriyoshi Koizumi <moriyoshi@php.net>2002-12-21 06:33:19 +0000
committerMoriyoshi Koizumi <moriyoshi@php.net>2002-12-21 06:33:19 +0000
commitf4883b916caf17536a366aa679f5f93b75537ebe (patch)
tree05de8ec9d9158986a548a8935f55b2e8030410bf /sapi
parent550aedb63d65a89f73dba20beef9ecae85490407 (diff)
downloadphp-git-f4883b916caf17536a366aa679f5f93b75537ebe.tar.gz
Added some notes about the brigade bug detection
Diffstat (limited to 'sapi')
-rw-r--r--sapi/apache2filter/sapi_apache2.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/sapi/apache2filter/sapi_apache2.c b/sapi/apache2filter/sapi_apache2.c
index 0355cf66cc..47fdc975f4 100644
--- a/sapi/apache2filter/sapi_apache2.c
+++ b/sapi/apache2filter/sapi_apache2.c
@@ -335,6 +335,16 @@ static int php_input_filter(ap_filter_t *f, apr_bucket_brigade *bb,
for (b = APR_BRIGADE_FIRST(bb); b != APR_BRIGADE_SENTINEL(bb); b = APR_BUCKET_NEXT(b)) {
apr_bucket_read(b, &str, &n, 1);
+
+ /*
+ * An intuitive brigade bug detection
+ * (http://bugs.php.net/18648)
+ *
+ * This has something to do with the issue mentioned in this thread
+ * on dev@httpd.apache.org:
+ *
+ * http://marc.theaimsgroup.com/?l=apr-dev&m=104039770818472&w=2
+ */
if (APR_BUCKET_IS_HEAP(b)) {
if ((str == prev_fetched_str && n == prev_fetched_str_len)) {
char *brigade_dump = NULL;