<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/php-git.git/tests/basic/timeout_variation_8.phpt, branch php-8.0.0beta1</title>
<subtitle>git.php.net: repository/php-src.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/'/>
<entry>
<title>Fix timeout tests</title>
<updated>2019-12-05T10:19:23+00:00</updated>
<author>
<name>Nikita Popov</name>
<email>nikita.ppv@gmail.com</email>
</author>
<published>2019-12-05T08:13:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=e760d94f4bb4d0802e89af0927cecfb479cba024'/>
<id>e760d94f4bb4d0802e89af0927cecfb479cba024</id>
<content type='text'>
After taking a more detailed look at our commonly failing timeout
tests... turns out that most of them are useless as written and
don't test what they're supposed to.

This PR has a couple of changes:

* Tests for timeout in while/for/foreach should just have the loop
as an infinite loop. Calling into something like busy_wait means
that we just end up always testing whatever busy_wait does.
* Tests for timeouts in calls need to be based on something like
sleep, otherwise we'd have to introduce a loop, and we'd end up
testing timeout of the looping structure instead. Using sleep only
works on Windows, because that's the only system where sleep counts
towards the timeout. As such, many of those tests are now Windows only.
* Removed some tests where I don't see a good way to test what they're
supposed to test. E.g. how can we test a timeout in eval() specifically?

The shutdown function tests are marked as XFAIL, as we are currently
missing a timeout check in call_user_function. I believe that's a
legitimate issue.

Closes GH-4969.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
After taking a more detailed look at our commonly failing timeout
tests... turns out that most of them are useless as written and
don't test what they're supposed to.

This PR has a couple of changes:

* Tests for timeout in while/for/foreach should just have the loop
as an infinite loop. Calling into something like busy_wait means
that we just end up always testing whatever busy_wait does.
* Tests for timeouts in calls need to be based on something like
sleep, otherwise we'd have to introduce a loop, and we'd end up
testing timeout of the looping structure instead. Using sleep only
works on Windows, because that's the only system where sleep counts
towards the timeout. As such, many of those tests are now Windows only.
* Removed some tests where I don't see a good way to test what they're
supposed to test. E.g. how can we test a timeout in eval() specifically?

The shutdown function tests are marked as XFAIL, as we are currently
missing a timeout check in call_user_function. I believe that's a
legitimate issue.

Closes GH-4969.
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve the error message in timeout tests</title>
<updated>2019-10-20T08:55:27+00:00</updated>
<author>
<name>Fabien Villepinte</name>
<email>fabien.villepinte@gmail.com</email>
</author>
<published>2019-10-20T08:55:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=62b053a3be3e77186451a503f93287a6002b62a0'/>
<id>62b053a3be3e77186451a503f93287a6002b62a0</id>
<content type='text'>
Closes GH-4818.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes GH-4818.
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace dirname(__FILE__) by __DIR__ in tests</title>
<updated>2019-03-15T21:55:30+00:00</updated>
<author>
<name>Fabien Villepinte</name>
<email>fabien.villepinte@gmail.com</email>
</author>
<published>2019-03-15T21:55:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=26dfce7f36d1c6f737ac241df1315a1b42b932c7'/>
<id>26dfce7f36d1c6f737ac241df1315a1b42b932c7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Trim trailing whitespace in tests</title>
<updated>2018-10-14T15:07:20+00:00</updated>
<author>
<name>Gabriel Caruso</name>
<email>carusogabriel34@gmail.com</email>
</author>
<published>2018-09-16T17:16:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=9c144e0d8217d1ef7a83c2498214308b21af749f'/>
<id>9c144e0d8217d1ef7a83c2498214308b21af749f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>use default test timeout</title>
<updated>2015-03-16T22:07:33+00:00</updated>
<author>
<name>Anatol Belski</name>
<email>ab@php.net</email>
</author>
<published>2015-03-16T22:07:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=b9bc84e29e09a7ed41eeee8f89a1fb0d6f85d522'/>
<id>b9bc84e29e09a7ed41eeee8f89a1fb0d6f85d522</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>test fixes + added skipif for slow tests</title>
<updated>2015-03-16T20:55:40+00:00</updated>
<author>
<name>Anatol Belski</name>
<email>ab@php.net</email>
</author>
<published>2015-03-16T20:55:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=fd51bd4a9efec93c8a400d0059af821671012c67'/>
<id>fd51bd4a9efec93c8a400d0059af821671012c67</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>use busy sleep instead of sleep() for timeout tests</title>
<updated>2015-03-16T20:21:33+00:00</updated>
<author>
<name>Anatol Belski</name>
<email>ab@php.net</email>
</author>
<published>2015-03-16T20:21:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=042dd8602e114253bddbd10a6df6c7bf24b3d7e5'/>
<id>042dd8602e114253bddbd10a6df6c7bf24b3d7e5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>test timeout with foreach loop</title>
<updated>2015-03-16T18:30:04+00:00</updated>
<author>
<name>Anatol Belski</name>
<email>ab@php.net</email>
</author>
<published>2015-03-16T18:30:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=33d832bd45978ca1f36d9db2d1341683f9ed786c'/>
<id>33d832bd45978ca1f36d9db2d1341683f9ed786c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
