<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/php-git.git/sapi/phpdbg/phpdbg_watch.c, branch php-8.0.0beta1</title>
<subtitle>git.php.net: repository/php-src.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/'/>
<entry>
<title>Use ZEND_UNREACHABLE() instead of ZEND_ASSERT(0)</title>
<updated>2020-06-16T16:39:09+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-06-16T14:29:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=92c4b0651368a4135f692af48f4716c96de4bd92'/>
<id>92c4b0651368a4135f692af48f4716c96de4bd92</id>
<content type='text'>
Instead of marking unreachable code with `ZEND_ASSERT(0)`, we introduce
`ZEND_UNREACHABLE()`, so that MSVC which does not consider `assert(0)`
to mark unreachable code does no longer trigger C4715[1] warnings in
debug builds.  This may be useful for other compilers as well.

[1] &lt;https://docs.microsoft.com/de-de/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4715?view=vs-2019&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of marking unreachable code with `ZEND_ASSERT(0)`, we introduce
`ZEND_UNREACHABLE()`, so that MSVC which does not consider `assert(0)`
to mark unreachable code does no longer trigger C4715[1] warnings in
debug builds.  This may be useful for other compilers as well.

[1] &lt;https://docs.microsoft.com/de-de/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4715?view=vs-2019&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix phpdbg watchpoints wrt. negative_array_index RFC</title>
<updated>2020-06-05T07:06:29+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-06-04T15:15:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=4ce47709c748f912849fac2b0c157a3274e27197'/>
<id>4ce47709c748f912849fac2b0c157a3274e27197</id>
<content type='text'>
The implementation of that RFC changed the initial value of
`zend_array.nNextFreeElement` to `-1`; we work around that by inserting
first, and retrieving the index afterwards.

We also fix the erroneous printf specifier for the unsigned integer.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The implementation of that RFC changed the initial value of
`zend_array.nNextFreeElement` to `-1`; we work around that by inserting
first, and retrieving the index afterwards.

We also fix the erroneous printf specifier for the unsigned integer.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.4'</title>
<updated>2020-06-02T13:19:32+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-06-02T13:19:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=486b8b1cd193fb5bb12d4810b18e076bb1f3933b'/>
<id>486b8b1cd193fb5bb12d4810b18e076bb1f3933b</id>
<content type='text'>
* PHP-7.4:
  Fix #73927: phpdbg fails with windows error prompt at "watch array"
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.4:
  Fix #73927: phpdbg fails with windows error prompt at "watch array"
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #73927: phpdbg fails with windows error prompt at "watch array"</title>
<updated>2020-06-02T13:17:40+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-05-27T16:26:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=af4a9bf1bf9109714e0e45aaf907e9809abb6217'/>
<id>af4a9bf1bf9109714e0e45aaf907e9809abb6217</id>
<content type='text'>
We expect zvals, so we should request zvals.

We also suppress spurious watchpoint removal notices.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We expect zvals, so we should request zvals.

We also suppress spurious watchpoint removal notices.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.4'</title>
<updated>2020-05-26T15:46:56+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-05-26T15:46:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=d2508ef94704b10332e2af2ed0c09d0012cffd69'/>
<id>d2508ef94704b10332e2af2ed0c09d0012cffd69</id>
<content type='text'>
* PHP-7.4:
  Enable phpdbg tests on AppVeyor
  Make phpdbg test portable
  Fix several mostly Windows related phpdbg bugs
  Fix #73926: phpdbg will not accept input on restart execution
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.4:
  Enable phpdbg tests on AppVeyor
  Make phpdbg test portable
  Fix several mostly Windows related phpdbg bugs
  Fix #73926: phpdbg will not accept input on restart execution
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix several mostly Windows related phpdbg bugs</title>
<updated>2020-05-26T15:45:25+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-05-25T17:12:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=8483a21f29fbfd8d86ddf2eb2b7db0ae0b462949'/>
<id>8483a21f29fbfd8d86ddf2eb2b7db0ae0b462949</id>
<content type='text'>
* Properly initialize PHPDBG_G(watch_tmp)

  Otherwise that may cause segfaults in ZTS builds.

* Deactivate potentially remaining watchpoints after REPL

  Otherwise the memory could still be protected, resulting in segfaults
  during shutdown.

* NULL zend_handlers_table after freeing

  As of commit 4130fe4[1], the `zend_handlers_table` is explicitly
  freed in the `zend_vm_dtor()`.  Since phpdbg (and maybe some other
  SAPIs) may restart the engine afterwards, we have to make sure that
  the table is also NULLed.

* Only set context option if there is a context

  In other words, we must not follow the null pointer.

* Cater to file handles without attached console

  File handles do not necessarily have an attached console (for
  instance, pipes do not), in which case `GetConsoleScreenBufferInfo()`
  fails.  In this case we set a default value (`40`) for lines like on
  other systems.

[1] &lt;http://git.php.net/?p=php-src.git;a=commit;h=4130fe437a5db7ead1444d3748bd0fbad9829cb2&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Properly initialize PHPDBG_G(watch_tmp)

  Otherwise that may cause segfaults in ZTS builds.

* Deactivate potentially remaining watchpoints after REPL

  Otherwise the memory could still be protected, resulting in segfaults
  during shutdown.

* NULL zend_handlers_table after freeing

  As of commit 4130fe4[1], the `zend_handlers_table` is explicitly
  freed in the `zend_vm_dtor()`.  Since phpdbg (and maybe some other
  SAPIs) may restart the engine afterwards, we have to make sure that
  the table is also NULLed.

* Only set context option if there is a context

  In other words, we must not follow the null pointer.

* Cater to file handles without attached console

  File handles do not necessarily have an attached console (for
  instance, pipes do not), in which case `GetConsoleScreenBufferInfo()`
  fails.  In this case we set a default value (`40`) for lines like on
  other systems.

[1] &lt;http://git.php.net/?p=php-src.git;a=commit;h=4130fe437a5db7ead1444d3748bd0fbad9829cb2&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix [-Wundef] warning in PHPDBG SAPI</title>
<updated>2020-05-12T20:02:51+00:00</updated>
<author>
<name>George Peter Banyard</name>
<email>girgias@php.net</email>
</author>
<published>2020-05-12T15:54:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=c0997130ec30f36ed1f87929b676f2521c84b2e2'/>
<id>c0997130ec30f36ed1f87929b676f2521c84b2e2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #78880: Another bunch of spelling errors</title>
<updated>2020-01-16T08:46:47+00:00</updated>
<author>
<name>Máté Kocsis</name>
<email>kocsismate@woohoolabs.com</email>
</author>
<published>2020-01-16T08:46:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=0b4778c377a5753a0deb9cfc697d4f62acf93a29'/>
<id>0b4778c377a5753a0deb9cfc697d4f62acf93a29</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove mention of PHP major version in Copyright headers</title>
<updated>2019-09-25T12:51:43+00:00</updated>
<author>
<name>Gabriel Caruso</name>
<email>carusogabriel34@gmail.com</email>
</author>
<published>2019-09-24T21:54:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=5d6e923d46a89fe9cd8fb6c3a6da675aa67197b4'/>
<id>5d6e923d46a89fe9cd8fb6c3a6da675aa67197b4</id>
<content type='text'>
Closes GH-4732.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes GH-4732.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix potentially uninitialized warnings in phpdbg</title>
<updated>2019-04-12T09:46:03+00:00</updated>
<author>
<name>Nikita Popov</name>
<email>nikita.ppv@gmail.com</email>
</author>
<published>2019-04-12T09:20:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=c09b63595ef7edcaae6638932dceae531c26c3cf'/>
<id>c09b63595ef7edcaae6638932dceae531c26c3cf</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
