<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/php-git.git/sapi/cli/php_cli_server.c, branch php-5.4.43</title>
<subtitle>git.php.net: repository/php-src.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/'/>
<entry>
<title>Fixed bug #66830 (Empty header causes PHP built-in web server to hang).</title>
<updated>2014-07-07T20:36:06+00:00</updated>
<author>
<name>Adam Harvey</name>
<email>aharvey@php.net</email>
</author>
<published>2014-07-07T20:36:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=604de67b7d0b8c6db76002011e3b55dd9c7aeec8'/>
<id>604de67b7d0b8c6db76002011e3b55dd9c7aeec8</id>
<content type='text'>
We had an infinite loop in sapi_cli_server_send_headers(): while iterating over
the linked list of headers, when an empty header was hit, continue would go to
the next iteration of the loop without updating h to be the next value in the
linked list. Updating it to always increment regardless of whether the header
is actually valid or not fixes the issue.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We had an infinite loop in sapi_cli_server_send_headers(): while iterating over
the linked list of headers, when an empty header was hit, continue would go to
the next iteration of the loop without updating h to be the next value in the
linked list. Updating it to always increment regardless of whether the header
is actually valid or not fixes the issue.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add 308 and 426 to the HTTP response code map in the CLI server.</title>
<updated>2014-06-13T00:54:29+00:00</updated>
<author>
<name>Adam Harvey</name>
<email>aharvey@php.net</email>
</author>
<published>2014-06-13T00:54:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=fe676748091e3329a8c8b053b7ce6fd41ae264e6'/>
<id>fe676748091e3329a8c8b053b7ce6fd41ae264e6</id>
<content type='text'>
Implements FR #67429 (CLI server is missing some new HTTP response codes).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Implements FR #67429 (CLI server is missing some new HTTP response codes).
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed bug #67406 built-in web-server segfaults on startup</title>
<updated>2014-06-10T08:28:34+00:00</updated>
<author>
<name>Remi Collet</name>
<email>remi@php.net</email>
</author>
<published>2014-06-10T08:28:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=58c6a08e00d4a8c99123cfb36f3a399a9b352d24'/>
<id>58c6a08e00d4a8c99123cfb36f3a399a9b352d24</id>
<content type='text'>
Reproduce on aarch64.

From select man page:
  "select() may update the timeout argument to indicate how much time was left."
So "const" is not ok.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Reproduce on aarch64.

From select man page:
  "select() may update the timeout argument to indicate how much time was left."
So "const" is not ok.
</pre>
</div>
</content>
</entry>
<entry>
<title>Bump year</title>
<updated>2014-01-03T03:04:26+00:00</updated>
<author>
<name>Xinchen Hui</name>
<email>laruence@php.net</email>
</author>
<published>2014-01-03T03:04:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=c0d060f5c02db168f1de895b41afffbc6e3cacfb'/>
<id>c0d060f5c02db168f1de895b41afffbc6e3cacfb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>- Fixed bug #65818 (Segfault with built-in webserver and chunked transfer encoding)</title>
<updated>2013-10-05T15:52:55+00:00</updated>
<author>
<name>Felipe Pena</name>
<email>felipensp@gmail.com</email>
</author>
<published>2013-10-05T15:52:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=3aaee86ee33af276d2e879f5a645cc6dc850de22'/>
<id>3aaee86ee33af276d2e879f5a645cc6dc850de22</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Handle CLI server request headers case insensitively.</title>
<updated>2013-09-09T23:24:49+00:00</updated>
<author>
<name>Adam Harvey</name>
<email>aharvey@php.net</email>
</author>
<published>2013-09-09T23:24:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=3c3b2b5bdc8e2bcff4d0e7d09375ad7af760b32a'/>
<id>3c3b2b5bdc8e2bcff4d0e7d09375ad7af760b32a</id>
<content type='text'>
Fixes bug #65633 (built-in server treat some http headers as case-sensitive).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes bug #65633 (built-in server treat some http headers as case-sensitive).
</pre>
</div>
</content>
</entry>
<entry>
<title>Reduce (some) compile noise of 'unused variable' and 'may be used uninitialized' warnings.</title>
<updated>2013-08-15T03:36:50+00:00</updated>
<author>
<name>Christopher Jones</name>
<email>sixd@php.net</email>
</author>
<published>2013-08-15T03:36:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=9ad97cd48903ea5454853960f2c14de326e0f624'/>
<id>9ad97cd48903ea5454853960f2c14de326e0f624</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix the spelling of the php_cli_server_http_response_status_code_pair typedef.</title>
<updated>2013-06-20T16:34:21+00:00</updated>
<author>
<name>Adam Harvey</name>
<email>aharvey@php.net</email>
</author>
<published>2013-06-20T16:34:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=f5c7fe92020fd7b8e81c94658da4813a7e6dea17'/>
<id>f5c7fe92020fd7b8e81c94658da4813a7e6dea17</id>
<content type='text'>
Specifically: php_cli_server_http_reponse_status_code_pair →
php_cli_server_http_response_status_code_pair.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Specifically: php_cli_server_http_reponse_status_code_pair →
php_cli_server_http_response_status_code_pair.
</pre>
</div>
</content>
</entry>
<entry>
<title>Change the search in get_status_string() to correctly handle unknown codes.</title>
<updated>2013-06-20T16:31:57+00:00</updated>
<author>
<name>Adam Harvey</name>
<email>aharvey@php.net</email>
</author>
<published>2013-06-19T18:32:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=283f56af6696f57400bdbf8ce29ee66e64249c0d'/>
<id>283f56af6696f57400bdbf8ce29ee66e64249c0d</id>
<content type='text'>
This previously used a buggy implementation of binary search that would loop
infinitely for unknown codes when searching in reason arrays of particular
sizes (such as the one we have at the moment). Since C provides bsearch(),
we'll just use that instead, since libc authors hopefully get this right.

There was also an additional bug that was masked by the first one: the design
was that an unknown code would result in get_status_string() returning NULL,
which would then result in a segfault in append_http_status_line(), since it
assumed that it would always receive a valid string pointer that could be
handed off to smart_str_appends_ex(). We'll now return a placeholder in that
case.

Fixes bug #65066 (Cli server not responsive when responding with 422 http
status code).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This previously used a buggy implementation of binary search that would loop
infinitely for unknown codes when searching in reason arrays of particular
sizes (such as the one we have at the moment). Since C provides bsearch(),
we'll just use that instead, since libc authors hopefully get this right.

There was also an additional bug that was masked by the first one: the design
was that an unknown code would result in get_status_string() returning NULL,
which would then result in a segfault in append_http_status_line(), since it
assumed that it would always receive a valid string pointer that could be
handed off to smart_str_appends_ex(). We'll now return a placeholder in that
case.

Fixes bug #65066 (Cli server not responsive when responding with 422 http
status code).
</pre>
</div>
</content>
</entry>
<entry>
<title>- add reminder for checking return values</title>
<updated>2013-03-24T12:27:00+00:00</updated>
<author>
<name>Pierre Joye</name>
<email>pierre.php@gmail.com</email>
</author>
<published>2013-03-24T12:27:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=bb18fa448c104c10d0899090bf64ca66e36e492e'/>
<id>bb18fa448c104c10d0899090bf64ca66e36e492e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
