<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/php-git.git/ext/sqlite3/tests, branch php-7.3.20</title>
<subtitle>git.php.net: repository/php-src.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/'/>
<entry>
<title>Enclose INI values containing {TMP} in quotes</title>
<updated>2020-03-09T21:49:08+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-03-09T16:58:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=d5e206620b80b0f198f6dd1865a758edf7ea1494'/>
<id>d5e206620b80b0f198f6dd1865a758edf7ea1494</id>
<content type='text'>
At least on Windows, the temporary directory may contain tilde signs,
which would result in an INI parse error.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
At least on Windows, the temporary directory may contain tilde signs,
which would result in an INI parse error.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #79294: ::columnType() may fail after SQLite3Stmt::reset()</title>
<updated>2020-02-21T12:36:29+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-02-21T12:24:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=f133f0024ec801dc9636ee5bf84a93de1300d4b2'/>
<id>f133f0024ec801dc9636ee5bf84a93de1300d4b2</id>
<content type='text'>
The fix for feature request #53466 did not properly handle resetting of
the corresponding statement; the problem with this is that the
statement does not know about its result sets.  But even if we could
fix this, the `complete` handling still appears to be brittle, since
the `sqlite3_column_type()`docs[1] state:

| If the SQL statement does not currently point to a valid row, or if
| the column index is out of range, the result is undefined.

Fortunately, we can use `sqlite3_data_count()` instead, since[2]:

| If prepared statement P does not have results ready to return (via
| calls to the sqlite3_column() family of interfaces) then
| sqlite3_data_count(P) returns 0.

Thus, we guard `SQLite3::columnType()` with `sqlite3_data_count()`, and
completely drop updating the `php_sqlite3_result_object.complete`
field, but keep it for ABI BC purposes.

[1] &lt;https://www.sqlite.org/c3ref/column_blob.html&gt;
[2] &lt;https://www.sqlite.org/c3ref/data_count.html&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The fix for feature request #53466 did not properly handle resetting of
the corresponding statement; the problem with this is that the
statement does not know about its result sets.  But even if we could
fix this, the `complete` handling still appears to be brittle, since
the `sqlite3_column_type()`docs[1] state:

| If the SQL statement does not currently point to a valid row, or if
| the column index is out of range, the result is undefined.

Fortunately, we can use `sqlite3_data_count()` instead, since[2]:

| If prepared statement P does not have results ready to return (via
| calls to the sqlite3_column() family of interfaces) then
| sqlite3_data_count(P) returns 0.

Thus, we guard `SQLite3::columnType()` with `sqlite3_data_count()`, and
completely drop updating the `php_sqlite3_result_object.complete`
field, but keep it for ABI BC purposes.

[1] &lt;https://www.sqlite.org/c3ref/column_blob.html&gt;
[2] &lt;https://www.sqlite.org/c3ref/data_count.html&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.2' into PHP-7.3</title>
<updated>2019-05-21T07:03:01+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2019-05-21T07:03:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=11740abd6ba1ee47e7a2a149c0ddfe6b7c8145cc'/>
<id>11740abd6ba1ee47e7a2a149c0ddfe6b7c8145cc</id>
<content type='text'>
* PHP-7.2:
  use {TMP} placeholder in phpt tests
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.2:
  use {TMP} placeholder in phpt tests
</pre>
</div>
</content>
</entry>
<entry>
<title>use {TMP} placeholder in phpt tests</title>
<updated>2019-05-21T07:02:37+00:00</updated>
<author>
<name>Holly Li (WIPRO LIMITED)</name>
<email>v-huli4@microsoft.com</email>
</author>
<published>2019-05-21T05:53:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=202e6936d6fa319fdda16c5c61d70ce19c2ecef6'/>
<id>202e6936d6fa319fdda16c5c61d70ce19c2ecef6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.2' into PHP-7.3</title>
<updated>2019-03-11T15:30:16+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2019-03-11T15:28:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=e7ce7c6bb211011569d8036b663bc4ccd45b9984'/>
<id>e7ce7c6bb211011569d8036b663bc4ccd45b9984</id>
<content type='text'>
* PHP-7.2:
  SQLite3: add DEFENSIVE config for SQLite &gt;= 3.26.0 as a mitigation strategy against potential security flaws
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.2:
  SQLite3: add DEFENSIVE config for SQLite &gt;= 3.26.0 as a mitigation strategy against potential security flaws
</pre>
</div>
</content>
</entry>
<entry>
<title>SQLite3: add DEFENSIVE config for SQLite &gt;= 3.26.0 as a mitigation strategy against potential security flaws</title>
<updated>2019-03-11T15:26:15+00:00</updated>
<author>
<name>bohwaz</name>
<email>github.bohwaz@miam.kd2.org</email>
</author>
<published>2018-12-16T21:52:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=e93259bb23500e26a7b0317cde9ad5398eec074e'/>
<id>e93259bb23500e26a7b0317cde9ad5398eec074e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.2' into PHP-7.3</title>
<updated>2018-11-29T01:18:56+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2018-11-29T01:18:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=471eb0dd95e58a5eae7d10b73d2fcb11031cf568'/>
<id>471eb0dd95e58a5eae7d10b73d2fcb11031cf568</id>
<content type='text'>
* PHP-7.2:
  Fix #77051: Issue with re-binding on SQLite3
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.2:
  Fix #77051: Issue with re-binding on SQLite3
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #77051: Issue with re-binding on SQLite3</title>
<updated>2018-11-29T01:16:57+00:00</updated>
<author>
<name>BohwaZ</name>
<email>bohwaz@github.com</email>
</author>
<published>2018-11-22T15:57:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=94ec262fca2e832ab2e1c4f03bc68cbda6aa42ae'/>
<id>94ec262fca2e832ab2e1c4f03bc68cbda6aa42ae</id>
<content type='text'>
We have to call `sqlite3_reset()` before re-binding the parameters.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We have to call `sqlite3_reset()` before re-binding the parameters.
</pre>
</div>
</content>
</entry>
<entry>
<title>Sync leading and final newlines in *.phpt sections</title>
<updated>2018-10-15T02:32:30+00:00</updated>
<author>
<name>Peter Kokot</name>
<email>peterkokot@gmail.com</email>
</author>
<published>2018-10-15T02:32:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=b746e6988743b46ccb0542d5d568eef0608ee296'/>
<id>b746e6988743b46ccb0542d5d568eef0608ee296</id>
<content type='text'>
This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines in all
*.phpt sections.

According to POSIX, a line is a sequence of zero or more non-' &lt;newline&gt;'
characters plus a terminating '&lt;newline&gt;' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines in all
*.phpt sections.

According to POSIX, a line is a sequence of zero or more non-' &lt;newline&gt;'
characters plus a terminating '&lt;newline&gt;' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
</pre>
</div>
</content>
</entry>
<entry>
<title>Sync leading and final newlines in *.phpt sections</title>
<updated>2018-10-15T02:31:31+00:00</updated>
<author>
<name>Peter Kokot</name>
<email>peterkokot@gmail.com</email>
</author>
<published>2018-10-15T02:31:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=f1d7e3ca0b70f910fcecef0278de9c15440ca3c0'/>
<id>f1d7e3ca0b70f910fcecef0278de9c15440ca3c0</id>
<content type='text'>
This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines in all
*.phpt sections.

According to POSIX, a line is a sequence of zero or more non-' &lt;newline&gt;'
characters plus a terminating '&lt;newline&gt;' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines in all
*.phpt sections.

According to POSIX, a line is a sequence of zero or more non-' &lt;newline&gt;'
characters plus a terminating '&lt;newline&gt;' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
</pre>
</div>
</content>
</entry>
</feed>
